ansaurus

Question

JavaScript subtraction problem

Answer 1

A:

It honestly looks fine, but you'd get better milage out of learning to use jQuery to do this. (press run).

dlamblin 2009-11-18 07:05:44

Answer 2

+1 A:

height = parseInt(document.getElementById("testDiv").offsetHeight);

This is probably not the problem, but you should always specify the base when using parseInt. It will interpret strings as base 8 if they start with 0

parseInt("011")     // 9
parseInt("011", 10) // 11

nickf 2009-11-18 07:06:27

Answer 3

+1 A:

Your problem is that when you do increasing=false; you don't call pause(30) again.

Just change your code like this :

if( height >= 304 ) { increasing = false; pause(30); }

this will work, I tested it :)

Edit: As stated by dlamblin, these kind of thing are easily done using JQuery, if your goal is the animation itself and not "how" it works, you should consider JQuery.

Soufiane Hassou 2009-11-18 07:06:32

Answer 4

+1 A:

It appears from your code, that once the DIV reaches the maximum height, "increasing" is set to false, but you don't call pause() again, so testFunction() never actually fires with "increasing" set to false.

richardtallent 2009-11-18 07:06:36

Answer 5

A:

I have changed your code and this works fine for me

Replace

height = parseInt(document.getElementById("testDiv").offsetHeight);

with

height = parseInt(document.getElementById("testDiv").style.height , 10);

and

if( height >= 304 ) {
                increasing = false;
        }

with

if( height >= 304 ) {
                increasing = false;
                pause(30);
        }

if( height <= 104 ) {
                increasing = true;
        }

with

if( height <= 104 ) {
                increasing = true;
                pause(30);
        }

Working Demo

rahul 2009-11-18 07:18:10

Answer 6

A:

You can also combine the IF loop and ELSE loop. Use:
i = height + (increasing) ? 4 : -4;
and then later on: `if (height<105 || height>303) increasing = !increasing;'

This way if you change a parameter, such as rate, then you only need to change it once.
--Dave

the Hampster 2009-11-18 07:32:53

Thank you everyone for your answers, I think I'm going to use jQuery :)

ehehhh 2009-11-18 19:12:32

ansaurus

tags:

views:

answers:

JavaScript subtraction problem

related questions