views:

589

answers:

1

This is a follow up to a previous question that I had before about passing an error back to the client, but also pertains to the ModelState.

Has anyone successful used the Nerd Dinner approach, but with Ajax? So Nerd Dinner does an update as so.

[AcceptVerbs(HttpVerbs.Post)]
    public ActionResult Edit(int id, FormCollection formValues) 
{
    Dinner dinner = dinnerRepository.GetDinner(id);
    try 
    {
        UpdateModel(dinner);
        dinnerRepository.Save();
        return RedirectToAction("Details", new { id=dinner.DinnerID });
    }
    catch 
    {
        foreach (var issue in dinner.GetRuleViolations()) {
        ModelState.AddModelError(issue.PropertyName, issue.ErrorMessage);
    }
        return View(dinner);
    }
}

Using jQuery $.ajax

function hijack(form, callback, errorFunction, format) {
    $.ajax({
        url: form.action,
        type: form.method,
        dataType: format,
        data: $(form).serialize(),
        success: callback,
        error: function(xhr, textStatus, errorThrown) {
            errorFunction(xhr, textStatus, errorThrown);
        }
    });
}

Ajax, the "try" part of the controller becomes

    try 
{
    UpdateModel(dinner);
    dinnerRepository.Save();
    return PartialView("PartialDetails", new { id=dinner.DinnerID });
}

, but what do you do about the catch part?

A simple error handling solution to send back an error would be

catch(Exception ex)
{
    Response.StatusCode = 500;                
    return Content("An Error occured.");
    //throw ex;
}

, but that doesn't pass through the robust modelstate built into MVC. I thought of a number of options, but I really want 2 things:

  1. I want the error to be handled in jQuery's error attribute.
  2. I want to use built in ASP.Net MVC validation logic as much as possible.

Is this possible? If not, what are the best alternatives that you know of?

Many thanks.

Update I haven't marked this as answered yet, because I haven't yet implemented what I think will work best.

I have decided that I don't really like the success => send refreshed list, failure => send error message approach that I was taking. I did this to reduce the number of calls, but a refreshed list is really being set to the page. Trying to do both tightly binds the popup to its overall page.

I am going to add a custom jQuery event refresh the master page list when the dialog closes. In essence, it's the observer pattern. I like the idea that the page says to the popup "tell me when you're done" (aka closed), without having to tell the popup why. It does require an additional call, but I don't see that as a big issue.

I'm still not sure how well that I like/dislike server-side validation and I'm considering going with client-side only validation. While server side validation seems like clean layering, it also has a number of problems, including:

1) It puts quality checks at the end, instead of the beginning. An analogy to manufacturing would be a car that's tested when it arrives at the dealer, instead at the points in the process where it's being built.
2) It violates the intent of Ajax. Ajax isn't just about sending asynchronous events, it's also about sending only what I need and receiving only what I need. Sending back the entire modelstate in order to provide error details doesn't seem to go with Ajax.

What I'm thinking about doing is having client-side only validation, but that server code and a custom viewmodel can be used to tell the client how to dynamically create those validation rules.

I also suspect that a dynamic language like IronRuby or IronPython might offer a more elegant way to solve these problems, but it could be a little longer before I look into that possibility.

+1  A: 

If i understand right what you are trying to do, my first answer will be no, you cannot use the model state as it is through and Ajax request. Maybe you can emulate the ModelState behavior, to display the errors:

  1. Passing a List<KeyValuePair<string,string>> (property,message) by JSON (this will require you to pass the modelErrors form the modelState to the new structure) and do the HTML construction of a Validation Summary by JS/jQuery (which i think is over killing solution).

  2. If you are going to the server, and there are any errors just do a render partial of the Html.ValidationSummary(), pass it through JSON and prepend it to the form. If everything was OK, just return the PartialDetails view and replace the actual content. This will require some kind of status parameter so you know what is coming back from the server on the ajax callback.

EDIT: This last option sounds good but tricky, because you will need to return a partial View in a string form by JSONResult, here is a question and solution about that hack http://stackoverflow.com/questions/483091/render-a-view-as-a-string/1241257#1241257.

Personally, i don't think that using the error attribute will do any good at all, i just use it to very specific situations like timeout errors, and server exceptions, not app exceptions.

EDIT: Using JSON

[AcceptVerbs(HttpVerbs.Post)]
        public ActionResult Edit(int id, FormCollection formValues)
        {
            Dinner dinner = dinnerRepository.GetDinner(id);
            try
            {
                UpdateModel(dinner);
                dinnerRepository.Save();
                return Json(new 
                {
                    result = "success",
                    html = this.RenderToString("PartialDetails", dinner) 
                });

            }
            catch
            {
                foreach (var issue in dinner.GetRuleViolations())
                {
                    ModelState.AddModelError(issue.PropertyName, issue.ErrorMessage);
                }
                return Json(new
                {
                    result = "failed",
                    html = this.RenderToString("PartialEdit", dinner)
                });
            }
        }

Here the result parameter will let you know what action to do in each case, just have to check it on the callback.

Omar
Thanks. Part of the challenge, however, is that I'd really prefer to send the results back as PartialView result and not as a JSON result. For 2., are you making 2 calls? One to return success/error and another to deliver the results? That is one option that I was thinking of.
John
Its really one call with this structure like {"status": [{"code": "error"}], "html" : [{"html":"a lot of html"}]}. If you want it to be just a partialView Result object, why don't just return the hole Edit partial View, in case that the model has errors? and the Details partial View when no errors occurs, the model State will work with no problems that way.
Omar
The part that makes my scenario different from most examples is that I want to do two very different actions based on whether it's a success or error. If it's an error, I can return the Edit partial View and recreate the dialog. However, if it's a success, I want to close the dialog and refresh the list on the main page. So the client side code needs to know if it's a success/failure in order to know which object to update -- the dialog or the list.
John
In that case i would suggest you go for a JSONResult type instead, because a plain PartialView type wont give you any state reference about what happened at the server side, unless you want to do 2 different request one for the stats and another for the partialView. I updated the Post with the Json Approach.
Omar