views:

1586

answers:

7

I am maintaining an app for a client that is used in two locations. One in England and one in Poland.

The database is stored in England and uses the format £1000.00 for currency, but the information is being gathered locally in Poland where 1000,00 is the format.

My question is, in VB6 is there a function that takes a currency string in a local format and converts to another, or will I just have to parse the string and replace , or . ?

BTW I have looked at CCur, but not sure if that will do what I want.

A: 

What database are you using? And what data type is the amount stored in?

As long as you are always converting from one format to another, you do not need to do any parsing, just replace "." with "," or the other way around. You may need to remove the "£"-sign as well if that is stored in your string.

Espo
A: 

@Espo the database is SS 2005 and format is English UK (whatever the page file type for that is).

I guess replacing the , is the easiest?

KiwiBastard
A: 

There's probably a correct answer dealing with culture objects and such, but the easiest way would be to taken the input from the polish input, and replace the , with a ., and then store it in your database as type "money" or "decimal". If you know they (possibly configurable per user) are always entering numbers in either Polish or English, you could have a function that you run all the input numbers through to convert the string to a proper "decimal" typed variable. Also, for display purposes you could run it through another similar function to ensure that the user always sees the number format they are comfortable with. The key here is to switch it to a decimal as soon as you get it from the user, and only switch it back to a string at the last step before sending it out to the user.

Kibbee
A: 

@KiwiBastard yes i would think so. Are you storing your amount in an "(n)varchar" field or are you using a currency/decimal type field? If the latter is the case, the currency-symbols and separators are added by your client, and there would be no need to replace anything in the database.

Espo
+6  A: 

The data is not actually stored as the string "£1000.00"; it's stored in some numeric format.

Sidebar: Usually databases are set up to store money amounts using either the decimal data type (also called money in some DBs), or as a floating point number (also called double).

The difference is that when it's stored as decimal certain numbers like 0.01 are represented exactly whereas in double those numbers can only be stored approximately, causing rounding errors.

The database appears to be storing the number as "£1000.00" because something is formatting it for display. In VB6, there's a function FormatCurrency which would take a number like 1000 and return a string like "£1000.00".

You'll notice that the FormatCurrency function does not take an argument specifying what type of currency to use. That's because it, along with all the other locale-specific functions in VB, figures out the currency from the current locale of the system (from the Windows Control Panel).

That means that on my system,

Debug.Print FormatCurrency(1000)

will print $1,000.00, but if I run that same program on a Windows computer set to the UK locale, it will probably print £1,000.00, which, of course, is something completely different.

Similarly, you've got some code, somewhere, I can't tell where, in Poland, it seems, that is responsible for parsing the user's string and converting it to a number. And if that code is in Visual Basic, again, it's relying on the control panel to decide whether "." or "," is the thousands separator and whether "," or "." is the decimal point.

The function CDbl converts its argument to a number. So for example on my system in the US

Debug.Print CDbl("1.200")

produces the number one point two, on a system with the Control Panel set to European formatting, it would produce the number one thousand, two hundred.

It's possible that the problem is that you have someone sitting a computer with the regional control panel set to use "." as the decimal separator, but they're typing "," as the decimal separator.

Joel Spolsky
A: 

Kia Ora @Joel - sorry I wasn't clear - the DB isn't storing the £ sign there is a Format$ function doing that when displaying to the screen - I didn't mean to put the £ sign on the original example above.

The problem is the app is expecting 1000.00 but is getting 1000,00 and was wondering if there is a better way than doing a string replace on the offending ","

I edited my answer. Let me know if that makes it clear. -- Joel

KiwiBastard
A: 

hello.. i'm jhong from phih.. a 2nd year computer programmer.. i need your help ah... i want to ask from you if you know the code of "currency to string convert" of visual basic..?.