Repeat Problem of tableview cell during scrolling in iphone

Question

There are 5 cells and each cell has one dynamic label. the height of cell is defined as per label content using heightForRowAtIndexPath method. Now, 3 cells are being displayed. When I scroll for next cells then cellForRowAtIndexPath is called once and In the output any one (4 OR 5) cell is displayed correctly but another has 1st cell content(repeating). Is there any solution to fix this? cellForRowAtIndexPath method should be called 2 times. I have defined sections and rows correctly.

Answer 1

You probably are not reusing the cells correctly. When you scroll, a previous cell is reused by the UITableView, but you don't change its contents correctly.

The code in cellForRowAtIndexPath should look similar to this:

- (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath
{
    static NSString *kCustomCellID = @"CustomCellID";

    UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:kCustomCellID];
    if (cell == nil)
    {
        cell = [[[UITableViewCell alloc] initWithStyle:UITableViewCellStyleValue1 reuseIdentifier:kCustomCellID] autorelease];
    }

    cell.textLabel.text = [self.dataArray objectAtIndex:indexPath.row];
    cell.detailTextLabel.text = [self.dateFormatter stringFromDate:[NSDate date]];

    return cell;
}

Does your look like this?

Answer 2

Hi Brij,

As you don't have a fixed size for each row, you won't be able to reuse them, except to present the same content again or some similar content.

My suggestion is to create a identifier for each row with different size.

You said that you have a switch to add the content based on the indexPath, so you should dequeue the reusable cells inside each case statement, based on its size.

Answer 3

The problem is that the cell is not nill so it returns same cell multiple times while scrolling. I removed the condition from cellForRowAtIndexPath method.

if (cell == nil)

Now each time, It is allocating cell and works fine.

Answer 4

Remove the judgement

if (cell == nil)

That's good.I solve my problem now.Thank you very much.