Using operator+ without leaking memory?

Question

So the code in question is this:

const String String::operator+ (const String& rhs)  
{  
    String tmp;  
    tmp.Set(this->mString);  
    tmp.Append(rhs.mString);  
    return tmp;  
}  

This of course places the String on the stack and it gets removed and returns garbage. And placing it on the heap would leak memory. So how should I do this?

Answer 1

You should implement a copy constructor, a copy assignment operator, and a destructor, according to the rule of three. Then the stack-allocated temporary will be safely copied to the storage accepting the return value.

Answer 2

Your solution doesn't return garbage if you have a working copy constructor - the String object tmp is copied into the result object before it is destroyed at the end of the block.

You could do this better by replacing

String tmp;
tmp.Set(this->mString);

with

String tmp(*this);

(you need a correctly working copy constructor for this, but you need it anyways for your return statement)

Answer 3

if you use std::string this neither leaks nor return garbage

does your class have a copy constructor (that works)

Either way it wont leak (unless String is very poorly designed, ie doesnt free its internal memory when its destructor gets invoked)

Answer 4

There is no memory leak. But you might want to change the return type to String instead of "const String". Otherwise this function wont be of much use