iPhone memory leak help

Question

This code is leaking, the performance tool blames two leaks on this block of code. If i comment it out the leak doesn't happen. Any help pinning it down would be greatly appreciated.

Leaks:

Malloc 48 bytes

NSCFarray 32 bytes

Code Block:

    NSArray *myArray = [[NSArray alloc] initWithObjects: @"Add", @"Edit", nil];
    segmentControl = [[UISegmentedControl alloc] initWithItems:myArray];
    [myArray release];
    [segmentControl setSegmentedControlStyle:UISegmentedControlStyleBar];
    [segmentControl setMomentary:YES];
    [segmentControl addTarget:self action:@selector(addOrEditPressed) forControlEvents:UIControlEventValueChanged];
    UIBarButtonItem *myBarButtonItem = [[UIBarButtonItem alloc] initWithCustomView:segmentControl];
    self.navigationItem.rightBarButtonItem = myBarButtonItem;
    [myBarButtonItem release];

Answer 1

Is segmentControl meant to be released?

Answer 2

myArray's retain count is still one after this section of code. When you add it to the initWithItems to create the segmentControl, it now has a reference to the object.

Is that possibly the leak?

Answer 3

As long as segmentControl is nil when you enter the code block and is being released somewhere else in your code (like dealloc or viewDidUnload) then you are doing nothing wrong.

Have you tried running your code under the static analyzer (Xcode menu: Build | Build & Analyze)?

Instruments can sometimes generate false positives when searching for leaks. If the leaked memory doesn't accumulate over time, your worst case scenario is that your program is leaking a total of 80 bytes. Leaks that grow over time are what you should be concerned about.

Answer 4

no alloc is required when you create the array

NSArray *myArray = [[NSArray alloc] initWithObjects: @"Add", @"Edit", nil];

use :

• (id)arrayWithObjects:(id)firstObj, ...

  try this way, this also do not need release

Answer 5

Is segmentControl a property? Do you nil it in viewDidUnload?