views:

3132

answers:

8

I have some numbers of different length (like 1, 999, 76492, so on) and I want to convert them all to strings with a common length (for example, if the length is 6, then those strings will be: '000001', '000999', '076492').

In other words, I need to add correct amount of leading zeros to the number.

int n = 999;
string str = some_function(n,6);
//str = '000999'

Is there a function like this in C++?

+1  A: 

There are many ways of doing this. The simplest would be:

int n = 999;
char buffer[256]; sprintf(buffer, "%06d", n);
string str(buffer);
Pramod
All hail sprintf!
Matt Curtis
in this case you might actually want to use:sprintf (buffer, "%06d", n);note the 0 in front of the 6 that you need to padd with zeroes
Nathan Fellman
A buffer of size 256 is _way_ overkill for this purpose. Even though the number can overflow 7 chars (which Isak's answer deals with, by using snprintf), still, no int I know of takes up 256 chars. :-P
Chris Jester-Young
Good point Chris. I think the largest int is actually just over 999,999,999,999,999, so char buffer[17] is perfectly safe, allowing for the \0 and possibly a sign (though I don't think the largest negative int would be anywhere near that long).
Matt Curtis
The largest int is implementation-dependent. Most modern compilers use a 32-bit two's complement int, meaning that the largest int is 2,147,483,647 and the longest int is the min int, -2,147,483,648. This is 12 chars long counting the terminating NUL. For portable code, an int can be ANY length.
Steve Jessop
First this isn't c++, and the largest int is 2147483648 which is only 10 characters long. Where you got the 999,999,999,999,999 from I have no idea. An unsigned it is larger, but still has the same number of characters.
graham.reeds
@graham: for a signed integer you also have to take a sign into account. The longest number is -2147483648 is 11 characters long (not counting a null-byte)
Leon Timmermans
Despite the supposed ease, sprintf is a bad solution. snprintf or stringstream are preferable.
Kristopher Johnson
Er, it was an attempt at comedy. Oops, wrong forum.
Matt Curtis
Stack space is free to allocate, and if you're going to overflow stack just because you allocated a 256 byte sized buffer, you've got bigger problems. While snprintf is indeed safer, it is only in C99. Stringstream is going to have to do some memory allocation under hood, so is slightly slower.
Pramod
I think you've been downvoted by C++ purists with lots of "lab" experience... you were doing alright until someone mentioned omfgstringstreams.
Matt Curtis
@Pramod: he wants a string at the end anyway, so memory allocation is needed there. I suspect (but can't be bothered to make sure) STL implementations will do no more allocation in xtofl's solution than in yours. Yours just saves it for the last line.
Steve Jessop
+1  A: 

sprintf is the C-like way of doing this, which also works in C++.

In C++, a combination of a stringstream and stream output formatting (see http://www.arachnoid.com/cpptutor/student3.html ) will do the job.

Chris Johnson
+7  A: 
char str[7];
snprintf (buf, 6, "%06", n);

See snprintf

Isak Savo
While it's good practice to always use snprintf() this is one of the few places where you can safely use sprintf().
Mark Baker
Yeah I know. But I tend to always use snprintf because there's really no reason not to (performance diff is negligible).
Isak Savo
arg #2 is a size_t, not a len, so it's 7, not 6. Better use sizeof however.
PW
A: 
// theNum = number to convert
// len    = desired length after padding
// str    = preallocated buffer to hold result, must have space for
//          (possibly negative?) result plus trailing null char.
void int2str(int theNum, int len, char *str)
{
     sprintf(str, "%*.*d", len, len, theNum);
}
Adam Liss
Yes, %d. Edited to reflect your correction. Thank you, Matt.
Adam Liss
+13  A: 

or using the stringstreams:

stringstream ss;
ss << setw(10) << setfill('0') << i;
string s = ss.str();

I compiled the information I found on arachnoid.com because I like the type-safe way of iostreams more. Besides, you can equally use this code on any other output stream.

xtofl
+2  A: 

stringstream will do (as xtofl pointed out). Boost format is a more convenient replacement for snprintf.

PW
A: 

This method doesn't use streams nor sprintf. Other than having locking problems, streams incur a performance overhead and is really an overkill. For streams the overhead comes from the need to construct the steam and stream buffer. For sprintf, the overhead comes from needing to interpret the format string. This works even when n is negative or when the string representation of n is longer than len. This is the FASTEST solution.

inline string some_function(int n, int len)
{
    string result(len--, '0');
    for (int val=(n<0)?-n:n; len>=0&&val!=0; --len,val/=10)
       result[len]='0'+val%10;
    if (len>=0&&n<0) result[0]='-';
    return result;
}
sep
+6  A: 

One thing that you may want to be aware of is the potential locking that may go on when you use the stringstream approach. In the STL that ships with Visual Studio 2008, at least, there are many locks taken out and released as various locale information is used during formatting. This may, or may not, be an issue for you depending on how many threads you have that might be concurrently converting numbers to strings...

The sprintf version doesn't take any locks (at least according to the lock monitoring tool that I'm developing at the moment...) and so might be 'better' for use in concurrent situations.

I only noticed this because my tool recently spat out the 'locale' locks as being amongst the most contended for locks in my server system; it came as a bit of a surprise and may cause me to revise the approach that I've been taking (i.e. move back towards sprintf from stringstream)...

Len Holgate
It does make sense that the locale is used, but indeed, that it is locked... Valuable info that is!
xtofl
It may only be the Visual Studio STL's that do this, I haven't checked with a test program built with STLPort. I also haven't investigated to see why it gets locked.
Len Holgate
STLPort 5.1.5 doesn't exhibit this cross thread contention problem, but the sprintf style of conversion is still around 3 times faster...
Len Holgate
Here it is the interesting post by Len Holgate: http://www.lenholgate.com/archives/000824.html
uvts_cvs