views:

351

answers:

1

I'm testing a C++ class with a number of functions that all have basically the same form:

ClassUnderTest t;

DATATYPE data = { 0 };
try
{
    t.SomeFunction( &data );
}
catch( const SomeException& e )
{
    // log known error
}
catch( ... )
{
    // log unknown error
}

Since there's a lot of these, I thought I'd write a function to do most of the heavy lifting:

template< typename DATA, typename TestFunction >
int DoTest( TestFunction test_fcn )
{
    DATA data = { 0 };
    try
    {
        test_fcn( &data );
    }
    catch( const SomeException& e )
    {
        // log known error
        return FAIL;
    }
    catch( ... )
    {
        // log unknown error
        return FAIL;
    }
    return TRUE;
}

ClassUnderTest t;
DoTest< DATATYPE >( boost::bind( &ClassUnderTest::SomeFunction, boost::ref( t ) ) );

But, the compiler doesn't seem to agree with me that this is a good idea...

Warning 1   warning C4180: qualifier applied to function type has no meaning; ignored   c:\boost\boost_1_41_0\boost\bind\bind.hpp   1657
Warning 2   warning C4180: qualifier applied to function type has no meaning; ignored   c:\boost\boost_1_41_0\boost\bind\mem_fn.hpp 318
Warning 3   warning C4180: qualifier applied to function type has no meaning; ignored   c:\boost\boost_1_41_0\boost\bind\mem_fn.hpp 326
Warning 4   warning C4180: qualifier applied to function type has no meaning; ignored   c:\boost\boost_1_41_0\boost\bind\mem_fn.hpp 331
Warning 5   warning C4180: qualifier applied to function type has no meaning; ignored   c:\boost\boost_1_41_0\boost\bind\mem_fn.hpp 345
Warning 6   warning C4180: qualifier applied to function type has no meaning; ignored   c:\boost\boost_1_41_0\boost\bind\mem_fn.hpp 350
Warning 7   warning C4180: qualifier applied to function type has no meaning; ignored   c:\boost\boost_1_41_0\boost\bind\mem_fn.hpp 362
Error   8   fatal error C1001: An internal error has occurred in the compiler.  c:\boost\boost_1_41_0\boost\bind\mem_fn.hpp 328

I'm using Visual Studio 2008 SP1. If anybody can point out what I'm doing wrong, I would appreciate it.

Thanks, PaulH

+4  A: 

The error is in your code, not in bind. You pass a functor that does not expect any arguments. Instead of your call, do

DoTest< DATATYPE >( boost::bind( &ClassUnderTest::SomeFunction, &t, _1) );

If you omit _1 then bind will create a zero-argument function object, and the member function (which expects a data pointer) will miss one argument when called by bind.

Johannes Schaub - litb
I could ignore the warnings, but I was hoping that whatever I could do to fix the warnings would also produce code that wouldn't make the compiler crash.
PaulH
So, is there a way to make this valid C++03?
PaulH
Johannes Schaub - litb
PaulH
Johannes Schaub - litb
@Johannes Schaub - It works! Thanks!
PaulH
@PaulH, i removed the text about const qualified function types. While it explains the warnings, it's not really relevant i think, and just introduced noises.
Johannes Schaub - litb