views:

320

answers:

2

I am trying to define a full specialization of std::basic_string< char, char_traits<char>, allocator<char> > which is typedef'd (in g++) by the <string> header.

The problem is, if I include <string> first, g++ sees the typedef as an instantiation of basic_string and gives me errors. If I do my specialization first then I have no issues.

I should be able to define my specialization after <string> is included. What do I have to do to be able to do that?

My Code:

#include <bits/localefwd.h>

//#include <string> // <- uncommenting this line causes compilation to fail

namespace std {
template<>
class basic_string< char, char_traits<char>, allocator<char> >
{
public:
    int blah() { return 42; }
    size_t size() { return 0; }
    const char *c_str() { return ""; }
    void reserve(int) {}
    void clear() {}
};
}

#include <string>
#include <iostream>

int main() {
    std::cout << std::string().blah() << std::endl;
}

The above code works fine. But, if I uncomment the first #include <string> line, I get the following compiler errors:

blah.cpp:7: error: specialization of ‘std::basic_string<char, std::char_traits<char>, std::allocator<char> >’ after instantiation
blah.cpp:7: error: redefinition of ‘class std::basic_string<char, std::char_traits<char>, std::allocator<char> >’
/usr/include/c++/4.4/bits/stringfwd.h:52: error: previous definition of ‘class std::basic_string<char, std::char_traits<char>, std::allocator<char> >’
blah.cpp: In function ‘int main()’:
blah.cpp:22: error: ‘class std::string’ has no member named ‘blah’

Line 52 of /usr/include/c++/4.4/bits/stringfwd.h:

  template<typename _CharT, typename _Traits = char_traits<_CharT>,
           typename _Alloc = allocator<_CharT> >
    class basic_string;

As far as I know this is just a forward delcaration of the template, NOT an instantiation as g++ claims.

Line 56 of /usr/include/c++/4.4/bits/stringfwd.h:

   typedef basic_string<char>    string;

As far as I know this is just a typedef, NOT an instantiation either.

So why are these lines conflicting with my code? What can I do to fix this other than ensuring that my code is always included before <string>?

+7  A: 

You are only allowed to specialize a standard library if the specialization depends on a user-defined name with external linkage. char doesn't meet this requirement and you are getting undefined behaviour.

This is specified in 17.4.3.1 [lib.reserver.names]/1.

The particular error that you are getting is because your implementation already instantiates the template that you are trying to specialize and, if you provide a specialization for any template, it must be before the template is ever instantiated with the parameters for which you want to provide the specialization.

14.7.3 [temp.expl.spec]/6

Charles Bailey
ISO C++03 17.4.3.1 "Reserved names": It is undefined for a C + + program to add declarations or definitions to namespace std or namespaceswithin namespace std unless otherwise specified. A program may add template specializations for anystandard library template to namespace std. Such a specialization (complete or partial) of a standardlibrary template results in undefined behavior unless the declaration depends on a user-defined name ofexternal linkage and unless the specialization meets the standard library requirements for the original template.)
Pavel Minaev
A: 

As a general rule, you should not define or specialize anything other than a traits class in namespace std, and you certainly should not attempt to change the definition of the underyling type of std::string.

Instead of specializing basic_string, you should create your own character datatype in your own namespace, then you should specialize std::char_traits for that type (but nothing else in namespace std), and then you should make a convenient typedef for basic_string instantiated with those types in your own namespace (not in namespace std, which belongs to the C++ standard and shouldn't be altered by users).

Michael Aaron Safyan
It's perfectly legal to specialize existing templates in `std`, so long as all rules are adhered to.
Pavel Minaev
Making your own char type and your own string has a completely different purpose than specializing std::string (to subtly change it's behavior).
SoapBox
@SoapBox, that may be so, but modifying a standard container, even if it were permitted, would still be a terrible thing to do and horribly confusing to other developers.
Michael Aaron Safyan