Simple IF statement question

Question

How can I simply the below if statements?

if ( isset(var1) & isset(var2) ) {

    if ( (var1 != something1) || (var2 != something2) ) {

        // ... code ...
    }

}

Seems like this could be condensed to only one IF statement but am not certain if I'd use an AND or OR

Answer 1

if (isset(var1) && ((var1 != something1) || (var1 != something2)))
    // ... code ...
}

You would use an and because you can only get to the // ... code ... part if both if-statements are true.

Answer 2

You can do:

if(isset(var1) && isset(var2) && ( (var1 != something1) || (var1 != something2) ) ){
    //..code
}   

As a general example:

if( cond1 && cond2 ) {
 if( cond3 || cond4) {
   // ...code..
 }
}

The code will be executed only when both cond1 and cond2 are true and either of cond3 or cond3 is true.

Answer 3

Boolean varsAreSets = isset(var1) & isset(var2); // or some other name that indicates what this is doing
Boolean someMeaningfulName = (var1 != something1) || (var2 != something2); // would suggest a meaningful name but don't know what this is accomplishing

if ( varsAreSets && someMeaningfulName ) { 
        // ... code ... 
} 

This makes the code very readable and helps you and whoever reads the code understand what these checks are actually doing.

Answer 4

if ( isset(var1) && isset(var2) && ( (var1 != something1) || (var2 != something2) ) ) {

    // ... code ...
}

Answer 5

It's a question of in what order your computer interprets boolean logic:

Take for example the following conditions:

A: False B: True

if you were to write if (A && B) what your computer actually does is think:

Is A true? No.

Well, A and B can't be true because A isn't true. Therefore this statement is false. [computer ignores the rest of the logic]

Because of this, when you evaluate the statement isset(var1) && ( (var1 != something1) || (var1 != something2) ) it first checks isset(var1) and if that's false, then it skips the rest of the condition, just like your double-if statement.

Answer 6

Another option:

if (isset(var1) && isset(var2)
&& !(var1 == something1 && var2 == something2)) {
   ...

Answer 7

I think most of the examples above that have 1 IF may spit out an error if var1 or var2 is NOT set

(isset($var1) && isset($var2)) ? ($var1!='something1' && $var2!='something2') ? $go=TRUE : $go=FALSE : $go = FALSE;

if ($go){
    echo 'hello';
}