views:

459

answers:

2

Just a small query...

I stumbled across the following shortcut in setting up a for loop (shortcut compared to the textbook examples I have been using):

for (Item *i in items){ ... }

As opposed to the longer format:

for (NSInteger i = 0; i < [items count]; i++){ ... } //think that's right

If I'm using the shorter version, is there a way to remove the item currently being iterated over (ie 'i')? Or do I need to use the longer format?

A: 

The former loop is a "for-each" loop in Objective C.

*i is a pointer to the direct item in the items-Array (most of the time this will be NSMutableArray).

This way you can operate directly on the item:

[items removeObject: i];

This (should) work - I am currently not working on my Mac and can't check it. However it might be that Objective-C Prevents removing objects while iterating over the collection (that is quite common in most languages).

Gjallar
It is indeed the case that you can't remove (or mutate) an `NSMutableArray` while enumerating over it, so the `removeObject:` call will raise an exception. (as explained by Vladimir in his answer)
Nick Forge
+6  A: 

You cannot remove objects from array while fast-enumerating it:

numeration is “safe”—the enumerator has a mutation guard so that if you attempt to modify the collection during enumeration, an exception is raised.

Anyway why do you need to change you container while enumerating it? Consider storing elements that need to be deleted and remove them from your container using removeObjectsInArray: or removeObjectsAtIndexes: method.

Vladimir
Thanks. I am changing it while enumerating it because it is a temporary queue. I'm moving all the items to another array.
Ben Packard
If you are moving *all* the objects to another array, try the following: `[destinationArray addObjectsFromArray: sourceArray]; [sourceArray removeAllObjects];`
JeremyP
Yep I found that - thanks.
Ben Packard