ansaurus

Question

Answer 1

A:

It's difficult to know exactly what is going on without the definitions of initializeConnection() and addNewChatClient().

Starkey 2010-05-15 11:27:11

Answer 2

+3 A:

This will take 100% of CPU:

        while (true) {
            try {

                initializeConnection();
                addNewChatClient();
                Thread.sleep(1000);

            } catch (Exception ex) {
            }
        }

       ....
       initializeConnection() throws Exception { 
          doSmth();
          throw new Exception ();
       }

That's why first of all handle the exception in that try-catch block. I think you'll easily find the problem after that.

Roman 2010-05-15 11:33:00

Hi Roman, i know the error. But i don't know how to avoid it. As i said it happens, when come client is already connected to socket and again redeploy my application.

Ankit Rathod 2010-05-15 11:52:31

Answer 3

+1 A:

In answer to your question yes it can if it never reaches

Thread.sleep(1000);

Because of an exception. Maybe this should be moved to the beginning of the try block or after the catch block so in the case a series of error occurs it doesn't retry immediately.

Though you would also be best off stopping this exception from occuring apart from in exceptional cases anyway.

Martin Smith 2010-05-15 11:35:11

Answer 4

+2 A:

I concurr that exceptions will cause the loop to spin continually with no pause - putting Thread.sleep() at the start of the loop will improve things.

That you are getting a ConcurrentModificationException hints that you are either modifying the collection during iteration over them in cleanupStreams() or some other thread is modifying the collection.

public ArrayList<ChatClient> getObjChatMembers() {
        return _objChatMembers;
    }

This seems a bit suspect, and a potential cause of the concurrent modification. If clients only need read access then change this to

public List<ChatClient> getObjChatMembers() {
        return Collecions.unmodifiableList(_objChatMembers);
    }

If the list of ChatClients can be modified, then you should take steps to ensure modifications are done in a thread-safe manner. This is a deep subject, but for starters, you can use Collections.synchronizedList() to ensure all operations are synchronized. Your iterator will also need to on this list, see the javadoc for that method for details.

mdma 2010-05-15 12:02:33

ansaurus

tags:

views:

answers:

Can this loop take out 100% CPU?

related questions