tags:

views:

125

answers:

3

This is the code:

#include <string>
#include <vector>
#include <iostream>
using namespace std;
class A {
public:
  virtual const string f() const { return "A"; }
};
class B : public A {
public:
  const string f() const { return "B"; }
};
int main(int ac, char** av) {
  vector<A> v;
  v.push_back(B());
  cout << v.at(0).f() << endl;
  return 0;
}

Expected result is B, but it's A. As I understand object slicing is taking place. How to avoid it? Shall I store pointers in vector instead of object instances? Is this the only choice?

+7  A: 

You need to store pointers. If these refer to dynamically allocated objects, use smart pointers.

sbi
+2  A: 

Well, in your code you could use a vector of B. Note that virtual functions will only be dispatched properly if called via a pointer or a reference. However, assuming you really want your vector to contain both A and B objects, you need to make it vector of A pointers, and create the A and B objects dynamically.

anon
+6  A: 

Ordered from most simple, to most complex (but most nice).

Solution 1:

vector<B> v;
v.push_back(B());
cout << v.at(0).f() << endl;

Solution 2:

vector<A*> v;
v.push_back(new B());
cout << v.at(0)->f() << endl;
while(!v.empty()) { delete v.back(); v.pop_back(); }

Solution 3:

vector<boost::shared_ptr<A>> v;
v.push_back(boost::make_shared<B>());
cout << v.at(0)->f() << endl;

If you don't want slicing to happen, you need to take into account the fact that different objects may have different sizes -- ergo you need a solution that can work with variable sizes -- that makes storing on the heap a must.

Kornel Kisielewicz
`vector<std::auto_ptr<A>> v;` is really bad idea. Never store `auto_ptr` in a vector, as its copy ctor modifies the passed object.See this:http://www.gotw.ca/publications/using_auto_ptr_effectively.htm for the reason.
Naveen
@Naveen, I know, yet it's the only pre-TR1 smart pointer.
Kornel Kisielewicz
@Kornel: I'm sure it's actually _forbidden_ to do that. `std::auto_ptr` doesn't meet the requirements for a container element.
sbi
@sbi, duh, I never use `auto_ptr` and mixed it up with `scoped_array` -_-, corrected
Kornel Kisielewicz
@Kornel: I turned down-vote into an up-vote.
sbi