Memory leak in object.

Question

Hi guys,

I am getting the memory leak in my objects setters can any one help me to resolve this??

Code:

  - (void)setEstimateTax2Type:(NSString *)aEstimateTax2Type
{

if ((!estimateTax2Type && !aEstimateTax2Type) || (estimateTax2Type && aEstimateTax2Type && [estimateTax2Type isEqualToString:aEstimateTax2Type])) return;

[estimateTax2Type release];
estimateTax2Type = [aEstimateTax2Type copy]  ;
}

Thank's in advance.

Monish.

Answer 1

Your conditional:

if (
  (!estimateTax2Type && !aEstimateTax2Type) || 
  (estimateTax2Type && aEstimateTax2Type && 
    [estimateTax2Type isEqualToString:aEstimateTax2Type])
) return;

Appears to terminate the function before releasing the memory:

[estimateTax2Type release];

Although I don't see any alloc

Answer 2

The easiest way to get the setter correct (for example your condition is entirely unnecessary):

//.h
@property (nonatomic, copy) NSString *estimateTax2Type;
//.m
@synthesize estimateTax2Type;

Answer 3

There's no problem with sending messages to nil. So your test can be:

if ([aEstimateTax2Type isEqualToString: estimateTax2Type])
{
    return;
}

However, that's not the cause of your leak. I suspect, you are not releasing estimateTax2Type in your dealloc method.

Answer 4

do you have a dealloc method to release estimateTax2Type when you're class is dealloced?

- (void)dealloc {
    [estimateTax2Type release];
    [super dealloc];
}