ansaurus

Question

Warning: Cannot modify header information (something wrong with a localization PHP file)

Answer 1

A:

make sure that there is no output before calling header(). also, check if your files have BOM(which comes before <?php and thus is output..).

kgb 2010-07-04 11:31:22

Answer 2

+2 A:

The cause of this error is that modifying the HTTP header requires that the HTTP header is not already sent to the client. And this happens when the first data is put out (either implicitly or explicitly). So with the first data that is put out, the HTTP header is sent along to the client and cannot be modified afterwards.

In your case, according to the error message, some function call tries to modify the HTTP header at /TEST/LOCALIZATION.PHP on line 10 but the output has already started at /TEST/INDEX.PHP on line 1.

To fix this you either need to make sure that the modification of the HTTP header happens before the first output is done (input-process-output model) or you buffer any output with PHP’s output control functions.

Gumbo 2010-07-04 11:39:01

@Gumbo I'm confused, is the problem in line 10 or line 14 (localization.php)?

janoChen 2010-07-04 11:40:58

@janoChen: The error occurs in *localization.php* but the cause of this error is in *index.php*. So if you fix the issue of premature output in *index.php* the HTTP header modifying function call in *localization.php* will succeed.

Gumbo 2010-07-04 11:46:07

@Gumbo sorry I'm a bit lost, does it have something to do with the position of <?phpinclude_once 'localization.php';?> (line number 1, 2 and 3 of index.php) or "(get_lang() ==" in line 17?

janoChen 2010-07-04 11:48:12

@janoChen: No. Just look at the positions given in the error message.

Gumbo 2010-07-04 11:51:27

Answer 3

+1 A:

The problem seems to be that the function l() calls set_lang(), after content is already sent to the browser. Meanwhile, set_lang() is trying to set a cookie, which must be done in the header, before any content is sent to the browser.

George Marian 2010-07-04 11:55:53

@George Marian thanks for the response. Is there any way of fixing this? Do I have to move the set_lang function?

janoChen 2010-07-04 12:01:13

Basically, l() needs to be modified, so that it doesn't call set_lang(). set_lang() would then need to be called somewhere else. Based on your other question, there's a difference between the function l() in the two files. In the original one, l() didn't set a cookie. That was done at the top of the file. So, what's happened is that l() has changed it's behavior between the two files. It's behavior in this version of localization.php is inappropriate for the way l() is being used.

George Marian 2010-07-04 12:11:18

@George Marian, Yes I was thinking to just use the working version of my previous post: http://stackoverflow.com/questions/3174353/two-simple-php-files-for-localization-that-do-basically-the-same-but-one-doesnt

janoChen 2010-07-04 13:11:58

@janoChen I was going to ask you why you were trying to use a different file or make changes. Other than pretty functions, I don't see much of a difference. Since you're not a PHP programmer, "improving" the code to use as a sample for some job application -- or whatever -- isn't the case for you.

George Marian 2010-07-04 13:24:33

@George Marian I know, but I thought that by simplifying a php file I could improve the quality of my website and learn PHP in the process. But If think you are right, maybe is not so much improvement between the working file and the one that doesn't work, I'm not very sure.

janoChen 2010-07-04 13:28:54

@janoChen Improvements can, indeed, be made to the original version of the file. However, the improvements aren't necessarily functionality improvements. They would basically be improvements to the syntax, which would make it easier to make future modifications to the functionality. In other words, I suggest you play around with PHP, follow some tutorials, do some research/readhing and then come back try these modifications. There's a bunch of basic stuff you need to get under your belt before you should attempt to refactor code. Good luck.

George Marian 2010-07-04 13:44:34

Answer 4

+1 A:

swap your localization.php for this one..

<?php
session_start();
header('Cache-control: private'); // IE 6 FIX

get_localization();

function get_localization()
{
    static $localization;
    if( empty($localization) ) {
        $lang = 'en';
        if(!empty($_GET['lang'])) $lang = $_GET['lang'];
        if(!empty($_SESSION['lang'])) $lang = $_SESSION['lang'];
        if(!empty($_COOKIE['lang'])) $lang = $_COOKIE['lang'];
        setcookie("lang", $lang, time() + (3600 * 24 * 30)); //line 14
        $_SESSION['lang'] = $lang;
        $lang_file = "languages/lang.$lang.php";
        if( !file_exists($lang_file) ) {
            if( !$lang_file = get_lang_file('en') ) {
                return false;
            }
        }
        include $lang_file;
        $localization = $lang;
    }
    return $localization;
}

function l($string){
    $l = get_localization();
    return is_array($l) && isset($l[$string]) ? $l[$string]: $string;
}
?>

should sort it

nathan 2010-07-04 12:46:32

@nathan Thanks for providing the code, but how should I call the CSS file with php in line 17?: <?php if(get_lang() == 'zh-tw' || get_lang() == 'zh-cn') {echo '<link rel="stylesheet" type="text/css" href="styles/chinese.css" />';} ?> I also tried: <?php if(get_lang() == 'zh-tw' || get_lang() == 'zh-cn') {echo '<link rel="stylesheet" type="text/css" href="styles/chinese.css" />';} ?>but in both cases it tells me that I'm calling an undefined function.

janoChen 2010-07-04 13:16:10

use if($_SESSION['lang'] == 'zh-tw' || $_SESSION['lang'] == 'zh-cn') instead :)

nathan 2010-07-04 13:43:08

ansaurus

tags:

views:

answers:

Warning: Cannot modify header information (something wrong with a localization PHP file)

related questions