views:

46

answers:

2

Hi,

Django does not respect the max_length attribute of TextField model field while validating a ModelForm.

So I define a LimitedTextField inherited from the models.TextField and added validation bits similar to models.CharField:

from django.core import validators

class LimitedTextField(models.TextField):
    def __init__(self, *args, **kwargs):
        super(LimitedTextField, self).__init__(*args, **kwargs)
        self.max_length = kwargs.get('max_length')
        if self.max_length:
            self.validators.append(validators.MaxLengthValidator(self.max_length))

    def formfield(self, **kwargs):
        defaults = {'max_length': self.max_length}
        defaults.update(kwargs)
        return super(LimitedTextField, self).formfield(**defaults)

But this still has no affect on ModelForm validation.

What am I missing? Any help is much appreciated.

Thanks,

oMat

+1  A: 

You can enforce a max length for a TextField by defining a CharField with a Textarea widget like this:

class MyClass(models.Model):
    textfield = models.TextField()

class MyForm(forms.ModelForm):
    textfield = forms.CharField(
        max_length = 50,
        widget = forms.Textarea
    )

    class Meta:
        model = MyClass
        fields = ('textfield',)
godshall
but then i should repeat this for every text field that i want to limit. it would be much better if nothing other then specifying max_length is required.
omat
Yes, specifying max_length in the model would be a little easier, but the solution I offered is the standard approach you will find in many django apps, and even within django itself (see django.contrib.comments). I have yet to see the custom TextField you are describing. Good luck.
godshall
+3  A: 

As of Django 1.2 this can be done by validators at model level, as explained here: http://docs.djangoproject.com/en/1.2/ref/validators/

from django.core.validators import MaxLengthValidator

class Comment(models.Model):
    comment = models.TextField(validators=[MaxLengthValidator(200)])
omat