views:

44437

answers:

21

When deploying the application to the device, the program will quit after a few cycles with the following error:

Program received signal: "EXC_BAD_ACCESS".

The program runs without any issue on the iPhone simulator, it will also debug and run as long as I step through the instructions one at a time. As soon as I let it run again, I will hit the EXC_BAD_ACCESS signal.

In this particular case, it happened to be an error in the accelerometer code. It would not execute within the simulator, which is why it did not throw any errors. However, it would execute once deployed to the device.

Most of the answers to this question deal with the general EXC_BAD_ACCESS error, so I will leave this open as a catch-all for the dreaded Bad Access error.

EXC_BAD_ACCESS is typically thrown as the result of an illegal memory access. You can find more information in the answers below.

Have you encountered the EXC_BAD_ACCESS signal before, and how did you deal with it?

+4  A: 

An EXC_BAD_ACCESS signal is the result of passing an invalid pointer to a system call. I got one just earlier today with a test program on OS X - I was passing an uninitialized variable to pthread_join(), which was due to an earlier typo.

I'm not familiar with iPhone development, but you should double-check all your buffer pointers that you're passing to system calls. Crank up your compiler's warning level all the way (with gcc, use the -Wall and -Wextra options). Enable as many diagnostics on the simulator/debugger as possible.

Adam Rosenfield
+4  A: 

In my experience, this is generally caused by an illegal memory access. Check all pointers, especially object pointers, to make sure they're initialized. Make sure your MainWindow.xib file, if you're using one, is set up properly, with all the necessary connections.

If none of that on-paper checking turns anything up, and it doesn't happen when single-stepping, try to locate the error with NSLog() statements: sprinkle your code with them, moving them around until you isolate the line that's causing the error. Then set a breakpoint on that line and run your program. When you hit the breakpoint, examine all the variables, and the objects in them, to see if anything doesn't look like you expect.I'd especially keep an eye out for variables whose object class is something you didn't expect. If a variable is supposed to contain a UIWindow but it has an NSNotification in it instead, the same underlying code error could be manifesting itself in a different way when the debugger isn't in operation.

Brent Royal-Gordon
Although this didn't help me in my specific situation, as the bad memory access ocurred in the accelerometer code which does not execute during a simulation, it did lead me to making more use of NSLog() statements. Thanks! I hope more people getting the EXC_BAD_ACCESS signal benefit from this thread
Hector Ramos
+39  A: 

From your description I suspect the most likely explanation is that you have some error in your memory management. You said you've been working on iPhone development for a few weeks, but not whether you are experienced with Objective C in general. If you've come from another background it can take a little while before you really internalise the memory management rules - unless you make a big point of it.

Remember, anything you get from an allocation function (usually the static alloc method, but there are a few others), or a copy method, you own the memory too and must release it when you are done.

But if you get something back from just about anything else including factory methods (e.g. [NSString stringWithFormat]) then you'll have an autorelease reference, which means it could be released at some time in the future by other code - so it is vital that if you need to keep it around beyond the immediate function that you retain it. If you don't, the memory may remain allocated while you are using it, or be released but coincidentally still valid, during your emulator testing, but is more likely to be released and show up as bad access errors when running on the device.

The best way to track these things down, and a good idea anyway (even if there are no apparent problems) is to run the app in the Instruments tool, especially with the Leaks option.

Phil Nash
I had some accelerometer sampling code that was not vital to my app, which after removal, eliminated the bad access error. Which makes sense considering the simulator does not have an accelerometer.I do find it weird that this code existed, untouched, for a week before causing this error...
Hector Ramos
I am new to Objective-C so most of my problems should arise from memory management. After a few years in C++, I've been using mostly Java for the last three or four years so I've gotten rusty on memory management. Thanks for your answer!
Hector Ramos
No problem - glad you fixed it. The memory management is not really hard to get on top of - you just need make sure you learn the rules and get into good habits.
Phil Nash
The problem I've had seems to be exclusively with being too aggressive in releasing strings (and such) that I create. I'm still not 100% sure on what should be released and when, but Phil's answer certainly helped.
pluckyglen
Man, coming from PHP this memory management stuff is a challenge. This answer helped a lot though. The code I had: NSDictionary *rowProduct = [self.products objectAtIndex:row]; cell.textLabel.text = [rowProduct objectForKey:@"name"]; cell.detailTextLabel.text = [rowProduct objectForKey:@"cost"];[rowProduct release]; return cell;Kept throwing this error. As soon as I deleted the [rowProduct release]; line everything worked properly. Hope that was the right thing to do...
cmcculloh
If I followed that correctly, cmculloh, yes that was the right thing to do. You do not own the object return from objectAtIndex.
Phil Nash
This explanation helped me tremendously.
BC
+1  A: 

NSAssert() calls to validate method parameters is pretty handy for tracking down and avoiding passing nils as well.

Ryan Townshend
+3  A: 

Not a complete answer, but one specific situation where I've received this is when trying to access an object that 'died' because I tried to use autorelease:

netObjectDefinedInMyHeader = [[[MyNetObject alloc] init] autorelease];

So for example, I was actually passing this as an object to 'notify' (registered it as a listener, observer, whatever idiom you like) but it had already died once the notification was sent and I'd get the EXC_BAD_ACCESS. Changing it to [[MyNetObject alloc] init] and releasing it later as appropriate solved the error.

Another reason this may happen is for example if you pass in an object and try to store it: myObjectDefinedInHeader = aParameterObjectPassedIn;

Later when trying to access myObjectDefinedInHeader you may get into trouble. Using: myObjectDefinedInHeader = [aParameterObjectPassedIn retain]; may be what you need. Of course these are just a couple of examples of what I've ran into and there are other reasons, but these can prove elusive so I mention them. Good luck!

Rob
+2  A: 

I've been debuging, and refactoring code to solve this error for the last four hours. A post above led me to see the problem:

Property before: startPoint = [[DataPoint alloc] init] ; startPoint= [DataPointList objectAtIndex: 0];
. . . x = startPoint.x - 10; // EXC_BAD_ACCESS

Property after: startPoint = [[DataPoint alloc] init] ; startPoint = [[DataPointList objectAtIndex: 0] retain];

Goodbye EXC_BAD_ACCESS

I made similar mistake. I forgot to reain the instance which caused crash and I spent hours to figure it out. Your experience lit me to find out mine. Thanks!
David.Chu.ca
+4  A: 

I've been debuging, and refactoring code to solve this error for the last four hours. A post above led me to see the problem:

Property before:

startPoint = [[DataPoint alloc] init] ;
startPoint= [DataPointList objectAtIndex: 0];
x = startPoint.x - 10; // EXC_BAD_ACCESS

Property after:

startPoint = [[DataPoint alloc] init] ;
startPoint = [[DataPointList objectAtIndex: 0] retain];

Goodbye EXC_BAD_ACCESS

Thank you so much for your answer. I've been struggling with this problem all day. You're awesome!

Aren't you just immediately overwriting startPoint? I don't think you need that first line at all.
toxaq
There is absolutely no need to allocate and initialise a variable if you're immediately going to overwrite it with another. You're just leaking the object in the first assignment.
dreamlax
+19  A: 

A major cause of EXEC_BAD_ACCESS is from trying to access released objects.

To find out how to troubleshoot this, read this document: DebuggingAutoReleasePool

Even if you don't think you are "releasing auto-released objects", this will apply to you.

This method works extremely well. I use it all the time with great success!!

In summary, this explains how to use Cocoa's NSZombie debugging class and the command line "malloc_history" tool to find exactly what released object has been accessed in your code.

Sidenote:

Running Instruments and checking for leaks will not help troubleshoot EXEC_BAD_ACCESS. I'm pretty sure memory leaks have nothing to do with EXEC_BAD_ACCESS. The definition of a leak is an object that you no longer have access to, and you therefore cannot call it.

bentford
That sidenote is very important. Leaks can't cause EXC_BAD_ACCESS (they have other problems). I wrote this to try to clear up misconceptions about EXC_BAD_ACCESS http://loufranco.com/blog/files/Understanding-EXC_BAD_ACCESS.html
Lou Franco
+3  A: 

Just to add another situation where this can happen:

I had the code:

NSMutableString *string;
[string   appendWithFormat:@"foo"];

Obviously I had forgotten to allocate memory for the string:

NSMutableString *string = [[NSMutableString alloc] init];
[string   appendWithFormat:@"foo"];

fixes the problem.

gnuchu
+2  A: 

Hope you're releasing the 'string' when you're done!

shnaps
+2  A: 

I just spent a couple hours tracking an EXC_BAD_ACCESS and found NSZombies and other env vars didn't seem to tell me anything.

For me, it was a stupid NSLog statement with format specifiers but no args passed.

NSLog(@"Some silly log message %@-%@");

Fixed by

NSLog(@"Some silly log message %@-%@", someObj1, someObj2);
scotth
+2  A: 

I find it useful to set a breakpoint on objc_exception_throw. That way the debugger should break when you get the EXC_BAD_ACCESS.

Instructions can be found here http://www.cocoadev.com/index.pl?DebuggingTechniques

lyonanderson
+1  A: 

I just had this problem. For me the reason was deleting a CoreData managed object ans trying to read it afterwards from another place.

konryd
+1  A: 

I forgot to return self in an init-Method... ;)

denbec
+2  A: 

Use the simple rule of "if you didn't allocate it or retain it, don't release it".

Gamma-Point
+1  A: 

Forgot to take out a non-alloc'd pointer from dealloc{}. I was getting the exc_bad_access on my rootView of a UINavigationController, but only sometimes. I assumed the problem was in the rootView because it was crashing halfway through its viewDidAppear{}. It turned out to only happen after I popped the view with the bad dealloc{} release, and that was it!

"EXC_BAD_ACCESS" [Switching to process 330] No memory available to program now: unsafe to call malloc

I thought it was a problem where I was trying to alloc... not where I was trying to release a non-alloc, D'oh!

Josh
+1  A: 

Just to add

Lynda.com has a fantastic DVD called

iPhone SDK Essential Training

and Chapter 6, Lesson 3 is all about EXEC_BAD_ACCESS and working with Zombies.

It was great for me to understand, not just the error code but how can I use Zombies to get more info on the released object.

balexandre
+2  A: 

This is an excellent thread. Here's my experience: I messed up with the retain/assign keyword on a property declaration. I said:

@property (nonatomic, assign) IBOutlet UISegmentedControl *choicesControl;
@property (nonatomic, assign) IBOutlet UISwitch *africaSwitch;
@property (nonatomic, assign) IBOutlet UISwitch *asiaSwitch;

where I should have said

@property (nonatomic, retain) IBOutlet UISegmentedControl *choicesControl;
@property (nonatomic, retain) IBOutlet UISwitch *africaSwitch;
@property (nonatomic, retain) IBOutlet UISwitch *asiaSwitch;
fool4jesus
+1  A: 

I encountered EXC_BAD_ACCESS on the iPhone only while trying to execute a C method that included a big array. The simulator was able to give me enough memory to run the code, but not the device (the array was a million characters, so it was a tad excessive!).

The EXC_BAD_ACCESS occurred just after entry point of the method, and had me confused for quite a while because it was nowhere near the array declaration.

Perhaps someone else might benefit from my couple of hours of hair-pulling.

mblackwell8
+1  A: 

How To Debug EXC_BAD_ACCESS

Check out the link above and do as it says.... Just some quick instructions for using NSZombies

Run the application and after it fails (Should display "Interrupted" rather than "EXC_BAD_ACCESS"... check the Console (Run > Console)... there should be a message there now telling what object it was trying to access.

-Ben

Ben Call
+3  A: 

The 2010 WWDC videos are available to any participants in the apple developer program. There's a great video: "Session 311 - Advanced Memory Analysis with Instruments" that shows some examples of using zombies in instruments and debugging other memory problems.

For a link to the login page click HERE.

Jonah
@Jonah Thanks for recommendation, I'll have a look
Prashant