views:

107

answers:

4

I have ported some code from Mingw which i wrote using code::blocks, to visual studio and their compiler, it has picked up many errors that my array sizes must be constant! Why does VS need a constant size and mingw does not?

e.g.

const int len = (strlen(szPath)-20);
char szModiPath[len];

the len variable is underlined in red to say that its an error and says "expected constant expression"

The only way i can think to get around this is....

char* szModiPath = new char[len];
delete[] szModiPath;

Will i have to change everything to dynamic or is there another way in VS?

+9  A: 

Why does VS need a constant size and mingw does not?

Because Variable Length Arrays are not a part of C++ although MinGW(g++) supports them as extension. Array size has to be a constant expression in C++.

In C++ it is always recommended to use std::vector instead of C-style arrays. :)

Prasoon Saurav
+6  A: 

The only way i can think to get around this is....

This is not "the only way". Use STL containers.

#include <string>

....
std::string s;
s.resize(len);

or

#include <vector>

....

std::vector<char> buffer(len);

P.S. Also, I don't think that using hungarian notation in C++ code is a good idea.

SigTerm
it just so happens my example is using an char string, i use arrays of integers and classes too :P and plus i'm doing windows programming, so i prefere using null terminating strings so that i can pass them to the windows api functions/calls, and i think the .c_str() member of std::string is constant, so i can't always pass it to windows functions.
UncleBens
@kaijethegreat: There's never a reason to put yourself in a position where you need to manually free something. Use a container that will do it for you, all the time.
GMan
A: 

Use _alloca to allocate variable amounts off the stack, then write an encapsulating class. It's a litlte messy, but you CAN write your own variable length stack-based arrays.

DeadMG
A: 

Check this out Variable Length Arrays right here on StackOverflow.

celavek