ansaurus

Question

Groovy/Grails SimpleTemplateEngine Freezes

Answer 1

+1 A:

Sounds like a synchronization issue. As a first step, you should create the template outside of the loop. Since there is no need to recreate the template every time.

    def ccIdToEmailMap = [:]
    def emailTemplateFile = Utilities.retrieveFile("email${File.separator}emailTemplate.gtpl")
    def engine = new SimpleTemplateEngine()
    def template = engine.createTemplate(emailTemplateFile)
    def clientContacts = ClientContact.list()
    for(ClientContact cc in clientContactList)
    {
            def binding = [clientContact : cc]
            def body = template.make(binding).toString()
            def email = [text: body, to: cc.emailAddress]
            ccIdToEmailMap.put(cc.id, email)
            println "added to map"
    }
    return ccIdToEmailMap

If it doesn't help, it might help if you'd post the template content and/or the source of ClientContact.

hth, Sigi

Siegfried Puchbauer 2008-12-16 08:47:33

I changed my code to what you have but it still causes freezing at 141. I tried just creating all the email bodies, but not sending and it works with 160+. There's something about sending these emails that causes problems. However, from my println statements, it appears to freeze before sending.

anschoewe 2008-12-16 18:07:38

Answer 2

A:

It appears that there was an issue with lazy loading my client contact owners in the template. Instead of expecting the owners to be loaded (inefficiently), while SimpleTemplateEngine is making the email body, I eagerly fetch the owners before binding/making the body.

My above code now looks like this:

 def emailTemplateFile = null
 def ccIdToEmailMap = [:]

 emailTemplateFile = Utilities.retrieveFile("email${File.separator}emailTemplate.gtpl")
 def engine = new SimpleTemplateEngine()
 def template = engine.createTemplate(emailTemplateFile)
 for(ClientContact cc in clientContactList)
 {
  //there was a locking problem when we tried to create the template for too many client contacts
  //i believe it was caused by lazy-fetching of the person/owners.  So, I fetch them before we bind
  //and make the email body.
  def criteria = ClientContact.createCriteria()
  cc = criteria.get {
   eq("id", cc.id)
   fetchMode('relationship', FM.EAGER)
   fetchMode('relationship.person', FM.EAGER)
  }
  def binding = [clientContact : cc]
  def body = template.make(binding).toString()
  def email = [text: body, to: cc.emailAddress]
  ccIdToEmailMap.put(cc.id, email)
 }

 return ccIdToEmailMap

It's still kind of inefficient to make that many queries for each of the client-contacts, but IT WORKS. I can't explain why lazy loading them during template making caused grails/groovy to freeze, but it did. If anyone can explain that, I would appreciate it.

Thank you for your answers. Siegfried... you got me started in the right direction.

Andrew

anschoewe 2008-12-16 23:09:02

ansaurus

tags:

views:

answers:

Groovy/Grails SimpleTemplateEngine Freezes

related questions