Best code review tool for GIT

views:

101

answers:

+2 Q:

Best code review tool for GIT

Is there a an open source or free code review tool that works best with GIT?

1.Have tried gerrit but is there a better open source or free code review tool?

2.Is there a code review that is capable of showing changes in the web before the user commits to the repository? Does ReviewBoard or any other tools have this feature?

+2 A:

Github has a built in facility called "Pull Requests". http://github.com/blog/712-pull-requests-2-0

It allows contributors to make code available for review before merging.

Joshua 2010-09-14 22:47:51

I like gerrit tremendously and spend huge amounts of time in it as a gateway for all of our development efforts.

Can you describe what you don't like about it? Certainly your #2 is handled quite well by it, as you can do per-line comments as you can see in this change that required a lot of dialog before the reviewers understood it.

Dustin 2010-09-14 22:51:27

i agree gerrit is really good and has a lot of features, but for review, i need to commit my changes in my local repository and push it up. Is there a way where i can see my changes before committing the changes and pushing it up to gerrit?

Senthil A Kumar 2010-09-14 23:23:05

No, and I really hope nobody makes such a tool because there's never an excuse for not committing your changes with git. Perhaps you just don't understand git and its optimal workflows. Give it a try without the fear that you'll make a mistake (that's why it's there). "bad" code will never make your project's history.

Dustin 2010-09-15 03:27:57

well, i got my answers with this tools "ReviewBoard" and what i expect is here in this tools and works excellent very much better than gerrit. It has post-commit review and pre-commit review which is really a nice feature.

Senthil A Kumar 2010-09-15 17:57:13

"very much better than gerrit" is rather pointless if you can't describe any way in which it's better. It sounds like you're just not familiar with git -- which is fine. If you're running a code review system on a centralized revision control system, then your concerns are valid. With a DVCS, you're just asking to make more work for you and your team.

Dustin 2010-09-16 01:52:02

Am not a GIT expert,just an SCM Admin trying out different tools. The code base that we use is really complicated and is spread across the WAN. Also we make use of GIT as both centralized (at toplevel) and distributed (at user level) for which we needed a code review tool that can do a pre-commit review which is not available in Gerrit. Other disadvantages, gerrit can recognize project repositories from a single directory only, each machines public key has to be stored in git (we are having >200 machines and each time a user has to copy the public key to gerrit),

Senthil A Kumar 2010-09-16 21:58:31

which is not interesting, diffs on completed merges conflicts (merge commit diff) doesn't show up, no administration rights to create groups (anyone can create spam groups). Anyways my team and i are very much happy with review board and may get back to gerrit when most of these issues are fixed. Anyways thanks for the suggestions guys :)

Senthil A Kumar 2010-09-16 22:08:18

TBH, I didn't understand everything you said, but the parts I did understand are wrong. I have paid developers on three continents. Anyone is permitted to contribute code. You can now. You can not, however, get code into our main codebase without it going through review. I can create groups on my system because I'm an admin. You're not, so you can't. Your PKI management problems are not gerrit's (I have lots of computers, myself). I'd happily help you with specific issues, but for the most part, you're talking about problems that don't exist.

Dustin 2010-09-17 05:22:54

Senthil A Kumar 2010-09-17 06:53:43

anyways am not going to use this tool, until the bugs are fixed, these bugs are valid and important. i agree gerrit may be great tool for you, but in my perspective and my needs is not satisfied by gerrit. my needs comprises of 600 devs who tested this. :) again not wishing to continue anymore on this thread. Thanks a lot for the suggestion, i will def try gerrit later when i see some bigger improvements.

Senthil A Kumar 2010-09-17 06:56:36

ansaurus

tags:

views:

answers:

Best code review tool for GIT

related questions