Expected expression before ')' token

Question

Hello!

I'm having problems with a program I'm trying to make in Objective-C.

I have a method that I'm trying in my MainViewController.m that is as follows.

- (void)updateLabels:(NSString *)text :(BOOL)isOn; 
{
[self setNameLabel:(text *); 
if (isOn)
 [self setOnLabel:(ON *);
else
  [self setOnLabel:(OFF *); 
}

My goal should be obvious from this code. I'm problably doing something terribly wrong to get the error message Expected expression before ')' token.

I'd appreciate any help!

Answer 1

This looks more like what you are trying to do, that is assign text to a label and then toggle whether its ON or OFF

#define ON YES
#define OFF NO
    - (void)updateLabels:(NSString *)text isOn:(BOOL)
        {
        [self setNameLabel:text]; 
        if (isOn)
         [self setOnLabel:ON];
        else
          [self setOnLabel:OFF]; 
        }

Answer 2

It should be:

 - (void)updateLabels:(NSString *)text status:(BOOL) isOn {
    ...

You need to remove the semi-colon after the method declaration. The second and subsequent parameters need both a field name (status) and a variable to put the value in (isOn).

In the interface declaration you swap the opening bracket for a semi-colon like this:

 - (void)updateLabels:(NSString *)text status:(BOOL) isOn;

Then calling it would look like this:

[... updateLabels:@"My label text" status:YES];

Answer 3

A couple problems here. First, you don't need that semicolon. Second, you don't need to pass pointers for ON and OFF:

- (void)updateLabelsWithText:(NSString *)text AndOnState:(BOOL)isOn {
    [self setNameLabel: text]; 
    if(isOn)
        [self setOnLabel:@"ON"];
    else
        [self setOnLabel:@"OFF"];
}