How should I approach code review from the public?

tags:

code-review

views:

answers:

+1 Q:

How should I approach code review from the public?

I'm currently working on a GAE CMS project and one thing that's been troubling me quite a bit each time I trying something new it's the fear of "I'm a doing this right".

What I'm looking for is idea/links of getting my code review by the public. I've found one site Refactormycode.com that I like. But from what I've seen soo far it's more for code part's and snippets. My own problem (i'm not a backend dev by trade) is more on architectural level. Is my approach correct? Will this solution really be stable on a big scale?

It some what feels a bit wrong to paste a url to the code repository and say "Hey, review this". Is there any site that collects people's entire project for review?

Also is there any negative sides to get you code publicly reviewed?

..fredrik

+2 A:

You should have not only code review but architecture review. Tell peers and seniors about your architectural decisions before implementing them. Discuss them.
Don't hesitate to show your code as often as you feel right. Just write email/im saying lets review/discuss my code. If your newer piece will be considered bad you have smaller piece to rewrite.
Don't be afraid about doing things wrong. The only persons that don't do anything wrong are the ones who don't do anything at all.

Andrey 2010-09-23 15:36:23

Thanks. Unfortunately, if I understand you correct, where I'm currently working there is no seniors developing applications with the same techniques as I do. I've gotten a bit of help since most architectural decisions goes across all programming. Maybe a stupid questions, but are stackoverflow a place to discuss architectural approaches?

fredrik 2010-09-23 15:49:03

@fredrik well, thats strange. Are you the most experienced developer working on that project? Seniors should be able to review even if they are not in the project and even if they are not working with same techniques. Yes, SO is good place to discuss but try to be as concrete as possible in your question, separate your concerns in different questions to get more granular answers.

Andrey 2010-09-23 15:56:04

Actually I'm the only dev on this project :) I've gotten some help, but when one can't for example use "left join" and need to be aware of the cpu usage in milliseconds they kinda look a bit suprised!

fredrik 2010-09-23 16:16:15

ansaurus

tags:

views:

answers:

How should I approach code review from the public?

related questions