ansaurus

Question

Answer 1

+3 A:

As a rule of thumb, any time you find yourself copying and pasting more than one or two lines of code, you should stop and think whether it would be cleaner to refactor that code into a function.

You can in this case create a function do_movie_specific_stuff() that takes as its arguments the data that is different between the three movies (if there is anything different between the three switch cases). Then each case in your switch statement is a single statement: a call to that function with the correct arguments.

James McNellis 2010-10-09 06:19:53

I strongly suspect that this person's class hasn't learned about writing custom functions yet. Early on, functions are only called, not written, and `int main()` is still just a magical incantation that goes at the top of a program.

Rob Kennedy 2010-10-09 16:08:11

Answer 2

+1 A:

I would recommend putting your logic into a loop and breaking your logic into functions, or possibly classes, if you're familiar. Something like this (this is non-compiled/non-tested semi-pseudo code... just to give you an idea):

bool done = false;
do
{
    cout << "Please choose a move (1, 2, or 3)" << endl;
    cin >> movieId;

    double price = getMoviePrice(movieId);
    cout << "The price of the movie is: " + price << endl;

    cout << "How many seats" << endl;
    cin >> seats;

    int availableSeats = getAvailableSeats(movieId);

    // and so on...  If the user indicates they want to quit, just set done to true!

} while (!done)

If you need to keep track of what movies the user has already tried, you can do that, you'll just have to keep track of that somewhere, and handle it in the logic.

Andy White 2010-10-09 06:26:37

Answer 3

A:

The code you have shown is a good example with the problems of purely linear code: It just doesn't work.

As a tip: I would either create three functions to handle each movie, or more preferably, create a generic function to handle all movies, which will take its data from some class:

class Movie {
  std::wstring name;
  int seats;
  int soldSeats;
  int pricePerSeat;
};

Alexander Rafferty 2010-10-09 06:58:32

ansaurus

tags:

views:

answers:

if else program to switch program

related questions