ansaurus

Question

Problem with organizing files in Visual C++ project

Answer 1

A:

I guess the header containing the definition of OSGFComponent must be included eigther in osgfdrawablecomponent.h or OSGFComponentManager.cpp in before including osgfdrawablecomponent.h

frag 2010-10-16 09:01:24

It is included.

Dani 2010-10-16 10:42:01

Answer 2

A:

Have you included OSGFComponent.h and Game.h in the osgfdrawablecomponent.h header file ?

Kiril Kirov 2010-10-16 09:07:53

Yes. The code is working properly when I remove the #include "OSGFComponentManager.h" from OSGFComponentManager.cpp.

Dani 2010-10-16 10:30:04

How it's working properly, as your declarations are in the header file (.h ) ? It's not possible, if you have only implementation in the cpp file. Or, OSGFComponentManager.h is included in some other header file, that's included in OSGFComponentManager.cpp ? Also, are you using #ifdef-#define-#endif macros ?

Kiril Kirov 2010-10-16 10:35:06

I'd suggest you to post your code here, if it's not very long, because all we can do is just to shoot in the dark, without seeing you're source.

Kiril Kirov 2010-10-16 10:37:34

Here is the source. http://bitbucket.org/dshaprin/osgf/src/tip/OSGF/ I also commented all method definitions in the OSGFComponentManager.cpp And I'm not using this class yet.

Dani 2010-10-16 10:49:00

Include "game.h" in "ScreenText.h" and in osgfcomponent.h, also uncomment all function bodies in "OSGFComponentManager.cpp" or you'll get a linking error. Also, there's no need from forward declarations (as class Game; when you'hv included the header Game.h). Delete this class OSGFComponent* dummy; in the osgfdrawablecomponent.h. Compile this and give me the new errors :)

Kiril Kirov 2010-10-16 11:03:24

I've pushed the new code. >d:\myprograms\osgf\osgf\osgfdrawablecomponent.h(6): error C2504: 'OSGFComponent' : base class undefined1>d:\myprograms\osgf\osgf\osgfdrawablecomponent.h(9): error C2061: syntax error : identifier 'Game'1>d:\myprograms\osgf\osgf\osgfdrawablecomponent.h(9): error C2065: 'game' : undeclared identifier1>d:\myprograms\osgf\osgf\osgfdrawablecomponent.h(11): error C2614: 'OSGFDrawableComponent' : illegal member initialization: 'OSGFComponent' is not a base or member1>d:\myprograms\osgf\osgf\osgfdrawablecomponent.h(15): error C2653: 'OSGFComponent' : is not a class or n

Dani 2010-10-16 11:53:35

I need to see the errors, to be able to help anyway. Or they're the same :?

Kiril Kirov 2010-10-16 11:54:30

They're the same.

Dani 2010-10-16 12:14:16

You haven't removed the forward declarations. Try without them. Also having Game in OSGFComponent is kinda dangerous. This way, the object 'game', you're passing to the constructor must be created with operator new.. use Game mGame; instead, just in case.

Kiril Kirov 2010-10-16 12:29:56

When i remove the forward declaration in OSGFComponent.h The compiler doesn't find Game class in this file and the old errors are still there. About the reference, I want to have one object for all components, not copy in every one of them.

Dani 2010-10-16 12:40:55

OK for the reference, sorry (: About the class Game - it's not possible. If the compiler does not find class Game, even when the Game.h is included, then the problem is in the Game.h file. Sorry, but I cannot compile it, as I use Linux and you're using some 3rd-party Windows libs, that I don't have in Linux.

Kiril Kirov 2010-10-16 12:51:13

Argh, you've a problem with this includes. Redesign them, because you're including Game.h in OSGFComponent.h, Game.h includes ScreenText.h, ScrenText.h includes osgfdrawablecomponent.h, which includes osgfcomponent.h, which again includes Game.h and so on. Definitely redesign is needed. Try to export the common parts into a different header, or use forward declarations somewhere. That's you're problem - this circus.

Kiril Kirov 2010-10-16 12:53:56

For example, you could try to remove #include "osgfdrawablecomponent.h" from ScreenText.h and use only forward declaration (as you're not actually using it in the cpp file), or try to remove #include "Game.h" from OSGFComponent.h and use only forward declaration. Something like this. Try them. Also, really redesign your things, this kind of includes are really confusing and unpleasant.

Kiril Kirov 2010-10-16 12:56:25

Thanks a lot. I removed #include "Game.h" and everything works fine now.

Dani 2010-10-16 16:07:04

I'm glad that I helped (:

Kiril Kirov 2010-10-16 20:42:17

ansaurus

tags:

views:

answers:

Problem with organizing files in Visual C++ project

related questions