ansaurus

Question

Code is extremely leaky.. I need help Identifying where the leaks are coming from.

Answer 1

A:

Because of the max character length of the question, Here is the rest of the info:

additional header file import statements:

#import "FlipsideViewController.h"
#import <UIKit/UIKit.h>
#import <Foundation/Foundation.h>
#import <MapKit/MapKit.h>

IBAction Header file statement:

-(IBAction)metalValueDidChange:(id)sender;

Additional Implementation File Methods:

 -(IBAction)metalValueDidChange: (id) sender {
     NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
     if([defaults integerForKey:@"metalControl"] == 0 ) 
     {
      [sender setTitle:@"Show Gold Mines" forState:UIControlStateNormal];
      [sender setTitleColor:[UIColor yellowColor ]forState:UIControlStateNormal];
      [defaults setInteger:1 forKey:@"metalControl"];
      [self loadAnnotations];
     }
     else if([defaults integerForKey:@"metalControl"] == 1)
     {
      [sender setTitle:@"Show Silver Mines" forState:UIControlStateNormal];
      [sender setTitleColor:[UIColor lightGrayColor]forState:UIControlStateNormal];
      [defaults setInteger:2 forKey:@"metalControl"];
      [self loadAnnotations];
     }
     else if([defaults integerForKey:@"metalControl"] == 2)
     {
      [sender setTitle:@"Show Copper Mines" forState:UIControlStateNormal];
      [sender setTitleColor:[UIColor orangeColor ]forState:UIControlStateNormal];
      [defaults setInteger:3 forKey:@"metalControl"];
      [self loadAnnotations];
     }
     else if([defaults integerForKey:@"metalControl"] == 3)
     {
      [sender setTitle:@"Show No Mines" forState:UIControlStateNormal];
      [sender setTitleColor:[UIColor blackColor ]forState:UIControlStateNormal];
      [defaults setInteger:0 forKey:@"metalControl"];
      [mapView removeAnnotations:mapView.annotations];
      [self loadAnnotations];
     }
     [defaults synchronize];
    }



   - (void)locationManager:(CLLocationManager *)manager didFailWithError:(NSError *)error
    {
        UIAlertView *alert = [[UIAlertView alloc] initWithTitle:@"Error" message:@"Your location could not be determined. iProspect Lite Cannot update your current location." delegate:nil cancelButtonTitle:@"OK" otherButtonTitles: nil];
        [alert show];
        [alert release];
    }

kevin Mendoza 2010-10-20 21:15:11

Spilling over like this is a hint that you're posting too much code with too little thought. You'll get a better response if you make some effort to narrow down the source of the problem before posting.

walkytalky 2010-10-20 21:22:27

Which Is what I have been trying to do. Idk, I feel like I should take this down now because of all the down votes, but I really have no other option : /.

kevin Mendoza 2010-10-20 21:27:02

Answer 2

A:

you should start releasing every object you are allocating after using it

JonLOo 2010-10-20 21:19:25

Even the ones he needs later on ? Seriously, not a good answer.

DarkDust 2010-10-20 21:22:04

no, maybe i went to fast, when i said after using it, i wanted to say when you finish using it..

JonLOo 2010-10-20 21:23:41

I know that concept, and Thought I could apply it properly using release on every initialized object after I was done using it, but apparently I didn't do it properly, and I can't figure out why.

kevin Mendoza 2010-10-20 21:28:56

Answer 3

+4 A:

have you analyzed your project with the static analyzer in xcode? If not, please do so, Build and Analyze in the Build-menu
The leak I found after a very quick look should be discoverable by the analyzer too.

-(void)loadAnnotations
....
NSMutableArray *minesArray=[[NSMutableArray alloc] init];
....
minesArray = [[managedObjectContext executeFetchRequest:request error:&error] mutableCopy];

fluchtpunkt 2010-10-20 22:55:18

+1 You figured out the error in the code mess.

Kinderchocolate 2010-10-21 00:01:07

Ok Changing those two lines to NSMutableArray *minesArray = [[managedObjectContext executeFetchRequest:request error: did eliminate a few leaks. I don't understand why though.

kevin Mendoza 2010-10-21 01:14:33

@kevin: because the first line allocated an array (that's what `alloc` means) that was never used or released before you lost the reference to it by replacing it with the copy of the fetch request. Remember the basic rules of memory management: balance every `alloc`, `copy`, `new`, or `retain` with a `release` or `autorelease`.

zem 2010-10-21 02:52:12

If you still don't understand, I strongly recommend you grab an Objective-C book.

Kinderchocolate 2010-10-21 03:39:37

Well no I get that now. I just had never heard of copy or new being the equivalent of an initialize statement.

kevin Mendoza 2010-10-21 04:02:03

@kevin: No, that's not the point. The point is you created a new object with retain count 1 (`[[NSMutableArray alloc] init]`) and then you overwrote the pointer to it without releasing it.

DarkDust 2010-10-21 05:22:12

So then I'm interpreting overwriting in objective C wrongly then. Ok, fair enough. So I thought it was - initialize -assign -release, but I guess I didn't assign it properly?

kevin Mendoza 2010-10-21 07:52:31

ansaurus

tags:

views:

answers:

Code is extremely leaky.. I need help Identifying where the leaks are coming from.

related questions