exc_bad_access from object returned from NSKeyedUnarchiver

Question

I am having trouble loading from saved data an instance of a custom class that conforms to the NSCoding protocol. My class has a UIImage property and when I assign a new UIImage to it the program crashes with an exc_bad_access.

In the view controller I declare my object like so:

@interface SomeViewController : UIViewController  {
    IBOutlet UIImageView *imageView;
    SomeClass *myObject;
 }

@property (nonatomic, retain) SomeClass *myObject;
@property (nonatomic, retain) IBOutlet UIImageView *imageView;

Then in the .m file it is used as following:

@synthesize myObject;
@synthesize imageView;

-(void)viewDidLoad{
  myObject = [NSKeyedUnarchiver unarchiveObjectWithFile:someDataPath];
  imageView.image = myObject.image;
}

So far so good. But later I pick a new image and try to set it to the "image" property of myObject, and this throws an exc_bad_access

-(void)imagePickerController:(UIImagePickerController *)picker didFinishPickingMediaWithInfo:(NSDictionary *)info {
  [picker dismissModalViewControllerAnimated:YES];
  UIImage *image = [info objectForKey:@"UIImagePickerControllerOriginalImage"];
  [imageView setImage:image];
   myObject.image = image;
}

As far as I can tell from single-stepping through the code, it is the last line which is causing the exc_bad_access. What am I doing wrong?

Answer 1

You have to retain myObject:

self.myObject = [NSKeyedUnarchiver unarchiveObjectWithFile:someDataPath];