This is my OAuth and TripIt controller. Is this sane?

Question

I am working on integrating the TripIt API into a project of mine. I'm new to OAuth so I'm learning this as I go. The following controller seems to be working. However, I want to make sure I'm not leaving any glaring security holes or just being stupid.

What do you guys/gals think?

If anyone had a better example, I would certainly study it as well.

Thanks for any pointers or suggestions.

http://gist.github.com/648227

Answer 1

Some tips:

• Don't require libs in methods; Add them to the top of the file, or include them in your config/environment.rb. That makes it easier to check what you include/require in your project.
• Add comments with how each methods is called and what it's supposed to do.
• You might want to consider (although not necessary) to move the actual 'oauth logic' to a special model, but the code relatively short, so it's okay in this case.

Otherwise this controller looks pretty good. Good use of before_filters and private methods.