SQL Join maybe?

Question

$query = mysql_query("SELECT * FROM news WHERE id = '{$_GET['id']}'"); $news = mysql_fetch_assoc($query);

$sql84 = mysql_query("SELECT username FROM users WHERE id = '".$news['user_id']."'") or exit(mysql_error()); $author = mysql_fetch_array($sql84);

is there i better way of doing this? a join maybe? how that look

Answer 1

$query = mysql_query("SELECT n.*, u.* FROM news n LEFT JOIN users u ON u.id=n.user_id WHERE n.id = ".intval($_GET['id']));

Please don't forget to use intval() if value assumed is numeric.

Answer 2

It seems like you want something like this:

(Edited to add error checking)

$q = "select username from news, users where news.user_id=users.id and news.id=".$_GET['id'].");";
$query = mysql_query($q) or die(mysql_error());

Ben

Answer 3

wow that was fast. nice site this is. thanks guys thats great. im new working with sql databses