tags:

views:

848

answers:

6

Hello,

why do we need to close a FileInputStream (and streams in general) in any case before we leave the program? What would happen otherwise? If the program stops before the input stream is closed explicitly in the program, doesn't the stream also close automatically?

Thank you.

+10  A: 

Yes, when the process terminates the unmanaged resources will be released. For InputStreams this is fine. For OutputStreams, you could lose an buffered data, so you should at least flush the stream before exiting the program.

Jon Skeet
+4  A: 

In addition to Jon's answer, it is generally a good idea to close any resource.

Think of a database connection. Your database cannot have infinite connections opened, in this case when you don't need it, it's better you close it as soon as you're done with it.

It is also good to make this a habit. "finally" block is your friend. In case of C++, you can also use RAII to manage this automatically.

artknish
+4  A: 

Sort of. The stream is backed by a "real" operating system file descriptor, and when the process terminates the OS will clean up any open file descriptors.

Anyway, it's good practice to always close your resources when you're done, so close the streams :)

João da Silva
+8  A: 

File handles are scarce, finite resources. You can run out of them if you don't clean them up properly, just like database connections.

If you've written a small program with just one user you can get away with being sloppy and not closing in a finally block.

But if you end up using that idiom in an application that has many users and file handles you might have a problem.

"First we make our habits, then they make us." I try to apply best practices even when they aren't necessary.

duffymo
+3  A: 

If you don't close streams, you may have problems opening them back up again. This is especially true if they're hanging off the end of sockets.

Closing a stream also makes sure that data is flushed through the stream if there is any data left to send.

Phil
+3  A: 

Dude. If you don't close your stream, your unit test will fail. Or at least, it should. So, that's why you need to close it. ;)

And while the OS will almost certainly clean up if you just exit, they'll generally get freed up faster if you explicitly close them. Furthermore, what if your code ends up in a long-running program sometime down the road? Then they'll have problems and curse you. :(

So, it's like washing your hands after using the bathroom. Eventually someone will pay the price if you don't do it. You can get away with it for a while, but it's still a good practice.

Don Branson
Just curious, why is this voted down? Seems like a good answer to me although funny :)
artknish
Naturally, I'd to know, too. :) But maybe the commenter just didn't appreciate that the answer is informative AND humorous.
Don Branson
I don't know either. For me it was helpful.