views:

1575

answers:

10

How to check if the binary representation of an integer is a palindrome?

+5  A: 

Since you haven't specified a language in which to do it, here's some C code (not the most efficient implementation, but it should illustrate the point):

/* flip n */
unsigned int flip(unsigned int n)
{
    int i, newInt = 0;
    for (i=0; i<WORDSIZE; ++i)
    {
        newInt += (n & 0x0001);
        newInt <<= 1;
        n >>= 1;
    }
    return newInt;
}

bool isPalindrome(int n)
{
    int flipped = flip(n);
    /* shift to remove trailing zeroes */
    while (!(flipped & 0x0001))
        flipped >>= 1;
    return n == flipped;
}

EDIT fixed for your 10001 thing.

rlbond
I like this solution due to its simplicity. It's very clear both in code and algorithmically.
Kevin
+2  A: 

Create a 256 lines chart containing a char and it's bit reversed char. given a 4 byte integer, take the first char, look it on the chart, compare the answer to the last char of the integer. if they differ it is not palindrome, if the are the same repeat with the middle chars. if they differ it is not palindrome else it is.

Liran Orevi
This doesn't scale well -- are you going to use a 2 billion line chart for a 32-bit integer?
rlbond
You don't need to - you only have to compare bytes at a time
Martin Beckett
Ah, of course. Of course, this doesn't work like he clarified.
rlbond
+1  A: 

I always have a palindrome function that works with Strings, that returns true if it is, false otherwise, e.g. in Java. The only thing I need to do is something like:

int number = 245;
String test = Integer.toString(number, 2);
if(isPalindrome(test)){
   ...
}
Raphael Montanaro
You "always have a palindrome function"?Why exactly?
foljs
Maybe you got me wrong.I mean that I have a palindrome function that works on Strings, and I can use it everywhere. Think once, use always.
Raphael Montanaro
The question is what is isPalindrome()'s implementation. But, specifically, with binary representations.
xanadont
String test = Integer.toString(number, 2);With this, the number will be represented in binary.The implementation is very simple. You loop till the middle of the String, and compare the char at the current position with the char on the respective position (test.length - current position). If they difer, you return false. When the loop is finished, you return true. =)
Raphael Montanaro
Raphael's answer makes complete sense, he just change the problem from working with binaries to working with a string, and solving if a string is a palindrome is fairly simple. The only caveat is that this question is tagged with c, c++
Javier
In C, you just convert the int to an array of chars, using itoa() (or the more supported sprintf()). After this, you just follow the previous steps. Quite easy =)
Raphael Montanaro
I agree with your approach. "The binary representation of an integer" is actually a string, in the same way as "The decimal representation of an integer" or "The hex representation of an integer" are. So dividing the problem into first obtain the string and then tell if it's a palindrome is correct.
Daniel Daranas
A: 

I think the best approach is to start at the ends and work your way inward, i.e. compare the first bit and the last bit, the second bit and the second to last bit, etc, which will have O(N/2) where N is the size of the int. If at any point your pairs aren't the same, it isn't a palindrome.

bool IsPalindrome(int n) {
    bool palindrome = true;
    size_t len = sizeof(n) * 8;
    for (int i = 0; i < len / 2; i++) {
        bool left_bit = !!(n & (1 << len - i - 1));
        bool right_bit = !!(n & (1 << i));
        if (left_bit != right_bit) {
            palindrome = false; 
            break;
        }
    }
    return palindrome;
}
jeffamaphone
Doesn't compile: bool right_bit = !!(n is missing a closing parentheses. Won't this will break if there are leading zeros e.g: 17?
dirkgently
But it is strange we used the same versions almost (including naming). In fact, I ran your code against mine to determine differences and compiler errors.
dirkgently
Fixed the missing paren. I am assuming, since the OP didn't specify, that the entire bitfield of the int must be a palindrome, not that we are ignoring leading zeros. But now that you mention it, it might make sense to do it that way.
jeffamaphone
sizeof(n); gives you the size in bytes, you need the size in bits.
dirkgently
Indeed. Fixed that too.
jeffamaphone
A: 

A generic version:

#include <iostream>
#include <limits>
using namespace std;

template <class T>
bool ispalindrome(T x) {
    size_t f = 0, l = (CHAR_BIT * sizeof x) - 1;
    // strip leading zeros
    while (!(x & (1 << l))) l--;
    for (; f != l; ++f, --l) {
        bool left = (x & (1 << f)) > 0; 
        bool right = (x & (1 << l)) > 0;
        //cout <<  left << '\n';
        //cout <<  right << '\n';
        if (left != right) break;
    }
    return f != l;
}       

int main() {
    cout << ispalindrome(17) << "\n";
}
dirkgently
+1  A: 

Plenty of nice solutions here. Let me add one that is not the most efficient, but very readable, in my opinion:

/* Reverses the digits of num assuming the given base. */
uint64_t
reverse_base(uint64_t num, uint8_t base)
{
  uint64_t rev = num % base;

  for (; num /= base; rev = rev * base + num % base);

  return rev;
}

/* Tells whether num is palindrome in the given base. */
bool
is_palindrome_base(uint64_t num, uint8_t base)
{
  /* A palindrome is equal to its reverse. */
  return num == reverse_base(num, base);
}

/* Tells whether num is a binary palindrome. */ 
bool
is_palindrome_bin(uint64_t num) 
{
  /* A binary palindrome is a palindrome in base 2. */
  return is_palindrome_base(num, 2);
}
Stephan202
+1  A: 

The following should be adaptable to any unsigned type. (Bit operations on signed types tend to be fraught with problems.)

bool test_pal(unsigned n)
{
  unsigned t = 0;

  for(unsigned bit = 1; bit && bit <= n; bit <<= 1)
    t = (t << 1) | !!(n & bit);

  return t == n;
}
Dingo
+1; my answer uses the same algorithm, but instead of shifting a mask left, it shifts the value n right
Christoph
A: 

Sometimes it's good to report a failure too;

There are lots of great answers here about the obvious way to do it, by analyzing in some form or other the bit pattern. I got to wondering, though, if there were any mathematical solutions? Are there properties of palendromic numbers that we might take advantage of?

So I played with the math a little bit, but the answer should really have been obvious from the start. It's trivial to prove that all binary palindromic numbers must be either odd or zero. That's about as far as I was able to get with it.

A little research showed no such approach for decimal palindromes, so it's either a very difficult problem or not solvable via a formal system. It might be interesting to prove the latter...

Chris Arguin
"all binary palindromic numbers must be either odd or zero" 0110 is neither odd nor zero, but can be considered a palindrome in base 2, it depends if you allow a palindrome to have leading zeros.
Eloff
A: 
 public static bool IsPalindrome(int n) {
  for (int i = 0;  i < 16; i++) {
   if (((n >> i) & 1) != ((n >> (31 - i)) & 1)) {
    return false;
   }
  }
  return true;
 }
+1  A: 

Hopefully correct:

_Bool is_palindrome(unsigned n)
{
    unsigned m = 0;

    for(unsigned tmp = n; tmp; tmp >>= 1)
     m = (m << 1) | (tmp & 1);

    return m == n;
}
Christoph