views:

126

answers:

1

In my test app, I want to style variable height table cells with a single pixel line at the top. This is the drawing code that I'm using, but it doesn't work.
Below is the code for the header:

// In OneLine.h
@interface OneLine : UIView {}
@end

And the drawing code:

// In OneLine.m
- (void)drawRect:(CGRect)rect {
    // Drawing code
    [[UIColor blackColor] set];
    UIRectFill(rect);
    [[UIColor whiteColor] set];
    UIRectFill(CGRectMake(rect.origin.x, rect.origin.y, rect.size.width, 1));
}
- (id)initWithFrame:(CGRect)frame {
    if (self = [super initWithFrame:frame]) {
        // Initialization code
        self.contentMode = UIViewContentModeTop;
    }
    return self;
}

The only problem is that I end up with a white line of variable height. It's not always one pixel tall. What am I doing wrong? I have a table view controller used to supply test cells. I initialize it like this:

// In MyTable.h
#import <UIKit/UIKit.h>

@interface MyTable : UITableViewController {
    NSMutableArray *data;
}
@end

With the code (only the added/changed methods from the default template).

// In MyTable.m
#import "MyTable.h"
#import "OneLine.h

@implementation MyTable
- (id)initWithStyle:(UITableViewStyle)style {
    if (self = [super initWithStyle:style]) {
        srand(time(NULL));
        data = [[NSMutableArray alloc] init];
        for (size_t index = 0; index < 200; ++index) {
            // Each cell has a different height betweet 40 and 50 pixels tall.
            [data addObject:[NSNumber numberWithInt:(rand() % 10) + 40.5]];
        }
    }
    return self;
}

- (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath {
    UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:@"Cell"];
    if (cell == nil) {
        cell = [[[UITableViewCell alloc] initWithStyle:UITableViewCellStyleDefault reuseIdentifier:@"Cell"] autorelease];
        cell.contentView.contentMode = UIViewContentModeTop;
        OneLine *view = [[OneLine alloc] initWithFrame:cell.contentView.bounds];
        [cell.contentView addSubview:view];
    }

    // Set up the cell...
    OneLine *view = [cell.contentView.subviews objectAtIndex:[cell.contentView.subviews count] - 1];
    // Build the correct frame
    view.frame = CGRectMake(0, 0, cell.contentView.bounds.size.width, [MyTable tableView:(UITableView*)self.view heightForRowAtIndexPath:indexPath]);
    return cell;
}

- (NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section {
    return [data count];
}

- (CGFloat)tableView:(UITableView *)tableView heightForRowAtIndexPath:(NSIndexPath *)indexPath {
    NSNumber *num = (NSNumber*) [data objectAtIndex:indexPath.row];
    return [num intValue];
}
@end

All of this code just creates a table view controller with 200 cells of random height (between 40 and 50 pixels tall.

A: 

Well, as it turns out, I found the solution to my own problem. In the code above, you'll see that the height of the table cells is not a round number (I corrected the code to show the real problem). In fact, when you have fractional height table cells, you're origin can be at a fractional pixel, and a rectangle or a line starting at the origin can leave a gap, and the final height of the cell might blend into the following cell. So, avoid fractional height tablecells

Douglas Mayle
Also, the rect parameter to drawRect: method is NOT the entire rect of the view, it is the rect of the area that is invalid and needs repainting (see setNeedsDisplayInRect:). In most cases, it will be equivalent to [self bounds], but if setNeedsDisplayInRect: is ever called, that might not be the case
rpetrich