views:

44

answers:

2

The following code is a modified version of XCode's iPhone square example, to draw a cube. But when I use culling, the cube renders with faces missing. Can anyone tell me what I'm doing wrong?

#import "ES1Renderer.h"

@implementation ES1Renderer

// Create an OpenGL ES 1.1 context
- (id)init
{
    if ((self = [super init]))
    {
        context = [[EAGLContext alloc] initWithAPI:kEAGLRenderingAPIOpenGLES1];

        if (!context || ![EAGLContext setCurrentContext:context])
        {
            [self release];
            return nil;
        }

        // Create default framebuffer object. The backing will be allocated for the current layer in -resizeFromLayer
        glGenFramebuffersOES(1, &defaultFramebuffer);
        glGenRenderbuffersOES(1, &colorRenderbuffer);
        glBindFramebufferOES(GL_FRAMEBUFFER_OES, defaultFramebuffer);
        glBindRenderbufferOES(GL_RENDERBUFFER_OES, colorRenderbuffer);
        glFramebufferRenderbufferOES(GL_FRAMEBUFFER_OES, GL_COLOR_ATTACHMENT0_OES, GL_RENDERBUFFER_OES, colorRenderbuffer);
        glEnable(GL_CULL_FACE);
        /*glEnable(GL_LIGHTING);
        glEnable(GL_LIGHT0);
        const GLfloat light0Ambient[] = {0.05, 0.05, 0.05, 1.0};
        glLightfv(GL_LIGHT0, GL_AMBIENT, light0Ambient);
        const GLfloat light0Diffuse[] = {0.5, 0.5, 0.5, 1.0};
        glLightfv(GL_LIGHT0, GL_DIFFUSE, light0Diffuse);
        const GLfloat light0Specular[] = {0.7, 0.7, 0.7, 1.0};
        glLightfv(GL_LIGHT0, GL_SPECULAR, light0Specular);
        const GLfloat light0Position[] = {0.0, 0.0, 1.0, 0.0}; 
        glLightfv(GL_LIGHT0, GL_POSITION, light0Position);
        const GLfloat light0Direction[] = {0.0, 0.0, -1.0};
        glLightfv(GL_LIGHT0, GL_SPOT_DIRECTION, light0Direction);
        glLightf(GL_LIGHT0, GL_SPOT_CUTOFF, 100.0); */
        glMatrixMode(GL_PROJECTION);
        glLoadIdentity();
        glOrthof(-1.0f, 1.0f, -1.5f, 1.5f, -1.0f, 1.0f);
        glScalef(0.5f, 0.5f, 0.5f);
        glMatrixMode(GL_MODELVIEW);
        glLoadIdentity();

    }

    return self;
}

- (void)render
{
    // Replace the implementation of this method to do your own custom drawing

    static const GLfloat squareVertices[] = {
        -0.5f,  -0.5f,   -0.5f, // 0
         0.5f,  -0.5f,   -0.5f, // 1

        -0.5f,   0.5f,   -0.5f, // 2
         0.5f,   0.5f,   -0.5f, // 3

        -0.5f,  -0.5f,    0.5f, // 4
         0.5f,  -0.5f,    0.5f, // 5

        -0.5f,   0.5f,    0.5f, // 6
         0.5f,   0.5f,    0.5f, // 7
    };

    static const GLubyte squareColors[] = {
        255, 0, 0, 255,
        0, 255, 0, 255,
        0, 0, 255, 255,
        255, 255, 255, 255,

        255, 0, 0, 255,
        0, 255, 0, 255,
        0, 0, 255, 255,
        255, 255, 255, 255,
    };

    static const GLubyte triangles [] = {
        0, 1, 2, // front
        1, 3, 2,
        2, 3, 6, // top
        3, 7, 6,
        6, 4, 5, // back
        5, 7, 6,
        4, 0, 1, // bottom
        1, 5, 4,
        4, 0, 2, // left
        2, 6, 4,
        1, 3, 5, // right
        3, 7, 5,
    };

  //  static float transY = 0.0f;

    // This application only creates a single context which is already set current at this point.
    // This call is redundant, but needed if dealing with multiple contexts.
    [EAGLContext setCurrentContext:context];

    // This application only creates a single default framebuffer which is already bound at this point.
    // This call is redundant, but needed if dealing with multiple framebuffers.
    glBindFramebufferOES(GL_FRAMEBUFFER_OES, defaultFramebuffer);
    glViewport(0, 0, backingWidth, backingHeight);


    glRotatef((GLfloat)1.0f, 0.0f, 0.0f, 1.0f);
   // transY++;

    glClearColor(0.0f, 0.0f, 0.0f, 1.0f);
    glClear(GL_COLOR_BUFFER_BIT);

    glVertexPointer(3, GL_FLOAT, 0, squareVertices);
    glEnableClientState(GL_VERTEX_ARRAY);
    glColorPointer(4, GL_UNSIGNED_BYTE, 0, squareColors);
    glEnableClientState(GL_COLOR_ARRAY);

    //int n = ((int)[[NSDate date] timeIntervalSince1970])/2;
    glDrawElements(GL_TRIANGLES, 36, GL_UNSIGNED_BYTE, triangles);


    // This application only creates a single color renderbuffer which is already bound at this point.
    // This call is redundant, but needed if dealing with multiple renderbuffers.
    glBindRenderbufferOES(GL_RENDERBUFFER_OES, colorRenderbuffer);
    [context presentRenderbuffer:GL_RENDERBUFFER_OES];
}

- (BOOL)resizeFromLayer:(CAEAGLLayer *)layer
{   
    // Allocate color buffer backing based on the current layer size
    glBindRenderbufferOES(GL_RENDERBUFFER_OES, colorRenderbuffer);
    [context renderbufferStorage:GL_RENDERBUFFER_OES fromDrawable:layer];
    glGetRenderbufferParameterivOES(GL_RENDERBUFFER_OES, GL_RENDERBUFFER_WIDTH_OES, &backingWidth);
    glGetRenderbufferParameterivOES(GL_RENDERBUFFER_OES, GL_RENDERBUFFER_HEIGHT_OES, &backingHeight);

    if (glCheckFramebufferStatusOES(GL_FRAMEBUFFER_OES) != GL_FRAMEBUFFER_COMPLETE_OES)
    {
        NSLog(@"Failed to make complete framebuffer object %x", glCheckFramebufferStatusOES(GL_FRAMEBUFFER_OES));
        return NO;
    }

    return YES;
}

- (void)dealloc
{
    // Tear down GL
    if (defaultFramebuffer)
    {
        glDeleteFramebuffersOES(1, &defaultFramebuffer);
        defaultFramebuffer = 0;
    }

    if (colorRenderbuffer)
    {
        glDeleteRenderbuffersOES(1, &colorRenderbuffer);
        colorRenderbuffer = 0;
    }

    // Tear down context
    if ([EAGLContext currentContext] == context)
        [EAGLContext setCurrentContext:nil];

    [context release];
    context = nil;

    [super dealloc];
}

@end
+1  A: 

The result of glEnable(GL_CULL_FACE) is not occlusion culling, but face culling, i.e. you're doing nothing wrong, everything works as expected. See http://www.opengl.org/resources/faq/technical/clipping.htm for further details.

To enable back-face culling, you additionally need to add glCullFace(GL_BACK), see the Wikipedia entry (http://en.wikipedia.org/wiki/Back-face_culling) for some further information.

As an aside: occlusion culling in OpenGL is usually performed using the Z buffer.

Greg S
+2  A: 

look at the first drawn triangle : its indices are 0,1,2. Try to imagine the corresponding triangle in 3d (or draw it). From the center of the world, the vertices are counter clockwise; from the other side of the face, they are clockwise.

By default, face culling culls face that are clockwise.

So you have two options :

  • Change the order of the indices in triangles[] : 2,1,0, ...
  • Change the default behaviour : glCullFace(GL_FRONT);
Calvin1602