views:

327

answers:

10

I've got lots of source code files written in various languages, but none of them have a standard comment at the top (sometimes even across the same project). Some of them don't have any header comment at all :-)

I've been thinking about creating a standard template that I can use at the top of my source files, and was wondering what fields I should include.

I know I want to include my name and a short description of what the file contains/does. Should I also include the date created? The date last modified? The programmer who last modified the file? What other fields have you found to be useful?

Any tips and comments welcome.

Thanks,
Cameron

+6  A: 

Date created, date modified and author who last changed the file should be stored in your source control software.

I usually put:

  • The main purpose of the file and things within the file.
  • The project/module the file belongs to.
  • The license associated with the file (and a LICENSE file in the project root).
  • Who is responsible for the file (either the team, person, or both)
Nick Presta
I agree. If you are only going to include one thing, at least be decent enough to include the license.
George Edison
A: 

Those useful fields that you mentioned are good ones. Who modified the file and when.

Your version control software should allow for the embedding of keywords within comments. For example, in CVS, the $Id$ will resolve to the file, date/time modified, and user that modified the file. It will automatically be kept up to date with each check-in.

rayd09
Ooh, cool, I didn't know that about CVS!
Cameron
But if you're using source control, why do you need comments?
ProfK
+10  A: 

This seems to be a dying practice.

Some people here on StackOverflow are against code comments altogether (reasoning that code should be written to be self explanatory) While I wouldn't go that far, some of the points of the anti-comment crowd make sense, such as the fact that comments tend to be out of date.

Header blocks of comments suffer from these symptoms even more so. Every organization I've been with that has had these header blocks, they are out of date. They have a author name of some guy who doesnt even work there any more, a description that does not match the code at all (assuming it ever did) and a last modified date, that once compared with version control history, seems to have missed its last dozen updates.

In my personal opinion, keep comments close to the code. If you want to know purpose of, and/or history of, a code file, use your version control system.

Neil N
That's assuming all my source code files are under version control :-) A lot of my older ones are not.
Cameron
If they are worth keeping, they belong in source control.
Neil N
I'm with Neil on this.
ProfK
+1. Though the "purpose of" the header would only slightly be in VC as part of the commit message; IMHO it's best to put that in the (internal) documentation. And that documentation might be in the same file, depending on style; of course if it's in a separate file, it should also be in VC. ;)
Roger Pate
I agree with Roger's comment. Information about changes in the file, who changed it, etc. seem best kept in version control, but I like the idea of putting a description of the purpose of the file in the header.
Cameron
+1  A: 

What fields do you need? If you have to ask whether to put some info there, you don't really need that info. Unless you are forced, by some bureaucratic incompetence of your employer, I don't see why you should go looking for more info than you already feel should be there.\

ProfK
Point taken. I was just having a good poke around in my source and I realized that my headers (if there were any) were completely inconsistent. I was asking the community for what *they* put because I'd like to know what they find useful (or not) to have, and by extension what I might find useful in the future (I don't really know what I'll need until the day I need it, which is too late :-)
Cameron
+1  A: 

You did not mention that you are using a version control system and your comment in Neil N's answer confirms this for your older code. While using version control is the best way to go I also have experienced many situations where the cost of doing so for older code would not be paid for by the project's sponsor. If you do not have a centralized change history for the project then the change history can be put in the modules. It is good that you are using a version control system for your new code.

Your company name
All rights reserved (c) year - or reference to appropriate license

Project or library this file is for

Module it belongs to

Description of what it contains

History
-------
01/08/2010 - Programmer - version
  Initial creation.  
01/09/2010 - Programmer - version
  Change description.
01/10/2010 - Programmer - version
  Change description.
fupsduck
Yes, version control is a must-have for all of my new projects. Unfortunately, many of my earlier ones aren't under version control because I didn't know that it existed back then!It's too late to add a version history to my old files now, but the top section of your suggestion looks good to me.
Cameron
+1  A: 

In most organizations, all source files have to begin with a legal blurb. If you're really lucky, it's just a one-liner, but in most cases it's a really long block of legalese. As a result, few people ever read these. Our eye just travels to the first program element and then goes up to its documentation.

So if you want to write anything, write it in association with the topmost program element, not the file.

Any other bookkeeping information should generally be part of your version control, not maintained (poorly) in the file itself.

Uri
+1  A: 

In addition to the comment above stating license, the project that it belongs to, etc I also tend to put the "weird" requirements at the top as well (such as "built with version X of library Y") so you, or the person who picks it up after you won't change something that the program relies on without realizing it (or, if they do, they will at least know what to change back)

James Hollingshead
+1  A: 

Back in 2002, when I was straight out of college and jobs were few and far between after the dot-com bust, I joined a service company which used to create software customized for their clients in Java. I had to sit in the office of a client (which was a ramshackle room in an electric sub-station rigged with an AC to keep the servers running), sharing chairs/PCs with other guys in the team. The other engineers (if I can call them engineers ;) in the group used to make changes ad-hoc to the source code, compile the files and put them into production.

  • No way to figure out who made what change.
  • No way to figure out why any change was made.
  • No way to go to previous version of code, unless the engineer "remembered" what he modified.
  • Backup: Copy over files from the production server, which were replaced with new files.
  • Location of backup: Home directory of engineer copying over files to production server.

Reports of production servers going down due to botched attempts of copying over files to the server (missed a file to be copied over, backups getting lost or wrong files being copied over or not all files being copied over) were met with shrugs (oh no, is it down? let's see what happened; hey who changed what recently...? ummm...).

During those days, after spending several frustrating days trying to figure out the whos and whys behind the code, I had devised a system for comments in a list in the header of the source file which detailed the following:

  1. Date of change made
  2. Who made the change
  3. Why was the change made

Two months later when the list threatened to challenge the size of the source code in the file, the manager had the bright idea of getting a source version control system.

I have never needed to put any comments in headers of source files (except for copyright notices) in any company I worked since. In my current company, everything else is mostly self-evident by looking at the code, or going to the bug reporting system which is integrated with the source version control system.

Sudhanshu
+1  A: 

A lot depends on whether you're using an auto-documentation generation tool or not.

While I agree with many of the comments, if you're using JavaDoc or some other documentation generating tool that depends on comments, you'll obviously need to include the things it wants to see.

Wade Williams
A: 

Include the following information:

  • What this file is for. That's a very useful piece of knowledge and it's more important than anything else. You should tell the reader, why there is such a file, why did you group functions in a separate file/package/module and why they are used. Maybe briefly, one or two lines, but that should be there.
  • Legal stuff, if appplicant.
  • Leave the place for special commands of console editors, such as of Emacs.
  • Add special commands that your auto-documenting system requires.

Things things you shouldn not include are

  • Who created the file
  • When it was created
  • Who modified it the last time
  • When it was last modified
  • What was added by the latest modification

You can--and should--retrieve it via the version control system, where it's constantly and automatically kept up-to-date. Let alone that most of these points are just useless.

Pavel Shved