ansaurus

Question

Answer 1

+5 A:

How about keeping an array of tests instead?

Then you can simply do something like:

int testresult = 0;
for(i = 0; i < 35; i++){
   if(test[i].hidden != YES){
       testresult = 1;
       break;
   }
}

if(testresult == 0){
   // all tests = yes
}

Note this uses C arrays rather than an NSArray. Principally you should switch from having a large collection of similarly named variables to an array of these things -- in ObjC it's advisable (as per the comments on this answer) to use an NSArray.

Mark E 2010-02-20 05:57:44

Why would he use a C array when he's programing in ObjC?

Colin Barrett 2010-02-20 06:05:42

@Colin, are C arrays not allowed in ObjC?

Mark E 2010-02-20 06:07:17

They are allowed, but NSArrays take care of the cleaning up of the objects they hold when they are released.

Eld 2010-02-20 06:11:46

Fair enough, my suggestion is primarily to change the storage format, I'm not advocating for C arrays and the solution here is one of concept rather than something ObjC specific.

Mark E 2010-02-20 06:14:15

Answer 2

+1 A:

http://developer.apple.com/mac/library/documentation/cocoa/Conceptual/KeyValueCoding/Concepts/BasicPrinciples.html#//apple_ref/doc/uid/20002170-BAJEAIEE

This may not be exact but something like:

BOOL retVal = test.hidden ;
for (int i = 2; i < 36 && retVal; ++i ) {
  id x = [self valueForKey:[NSString stringFromFormat:@"test%d", i]];
  retVal = retVal && x.hidden ;
}
if ( retVal ) {
  // do something
}

Though I think storing the test objects in an NSArray would be better.

Eld 2010-02-20 06:00:24

Answer 3

+6 A:

Assuming you meant tag as in the -tag method on UIView, and these views are all in containerView

BOOL allHidden = YES;
for (int i = 1; allHidden == YES && i <= 35; i++) {
    allHidden = [[containerView viewWithTag:i] isHidden];
}
if (allHidden) {
   do_something();
}

Colin Barrett 2010-02-20 06:04:44

Answer 4

+1 A:

Are they all contained in the same superview? If so, try this to take advantage of the fact that they're already in an array:

@implementation UIView (testForHiddenSubviews)

- (BOOL) hasHiddenSubviews
  {
  for (UIView *view in self.subviews)
   if (view.hidden) 
    return YES;
  return NO;
  }

- (BOOL) allSubviewsHidden
  {
  for (UIView *view in self.subviews)
    if (!view.hidden) 
      return NO;
  return YES;
  }

@end

NSResponder 2010-02-20 10:21:16

ansaurus

tags:

views:

answers:

Shorter way to write this code?

related questions