tags:

views:

421

answers:

4
Q: 

onSubmit returning false is not working

I'm completely confused ... I'd swear this was working yesterday ... I woke up this morning and all my forms stopped to work in my project.

All the forms have a "onsubmit" to a function that returns false since it's an ajax call, so the form is never sent.

After a lot of tests, I simplified the question to this piece of code:

<html>
<head>
<script type="text/javascript">
 function sub()
 {
  alert ("MIC!");
  return false;
 }
</script> 
</head>
<body>

<form method = "post" id = "form1" onsubmit = "return sub()">
 input: <input type="text" name="input1" >
    <a href="#" onClick="document.getElementById('form1').submit();">button</a> 
</form>

</body>
</html>

I would swear that this works perfectly, but today is nor working :D

Why if I press the button the form is sent ?

I know it's a total newbie question, but I'm stuck

Thank you !

A: 

Try to change you "button" code like that

<a href="#" onClick="return document.getElementById('form1').onsubmit();">button</a>
Olegas  2010-03-30 09:08:27
A: 

The onsubmit event only fires for normal form submissions. It does not fire when the JavaScript submit() method is called.

The best solution is to use a normal submit button here.

If you want to continue with using a link to the top of the page (which isn't unobtrusive, progressive, or graceful) then you need to call the sub() function explicitly and test its return value before deciding if you should call submit() or not.

David Dorward  2010-03-30 09:09:27
A: 

Browsers do not call the onSubmit event on the form if you call submit() programmatically.

Andy Shellam  2010-03-30 09:12:26
Andy ... I swear you that was working yesterday :)I have a whole project with those kind of structures, and the form was never submitted ...It has to be other thing ... :P
StuckOnSubmit  2010-03-30 09:16:41
The submit event would not fire with this code. THREE separate answers all say that! Either you are wrong, or your test case doesn't sufficiently represent your actual code.
David Dorward  2010-03-30 10:01:46
Are you sure you didn't have an actual submit button? As that would then work. Perhaps you changed your submit buttons for anchors as an enhancement yesterday? Do you have a source control system? Are other developers also working on the project that could have changed it?
Andy Shellam  2010-03-30 10:06:50
A: 

It seems that the 'submit()' function bypasses the 'form' tags 'onsubmit' event in Firefox and IE8. If you use a submit button, then it works as expected:

<html>
<head>
<script type="text/javascript">
 function sub()
 {
  alert ("MIC!");
  return false;
 }
</script> 
</head>
<body>

<form method = "post" action="http://google.com" id = "form1" onsubmit = "return sub();">
 input: <input type="text" name="input1" >
     <input type="submit">
</form>

</body>
</html>
 2010-03-30 09:22:23

related questions

How do you call an ASHX from JavaScript?
return eats exception
Boolean expressions in Java
Coding practice: return by value or by reference in Matrix multiplication?
flex3 function not returning String properly
return statement vs exit() in main()
VB.NET Function Return
make a parent function return - super return?
I need help--lists and Python
ajax Return Data Not working in JQuery
PHP Return from function in another file
JQuery Ajax Return value
JQuery AJAX Return Link Not Working
Set Variable from an Array directly into a List of Variables in Java
Is returning early from a function more elegant than an if statement?
Problem with return statement
What is the best way to return an error from a function when I'm already returning a value?
Returning an interface from a WCF service
Will the c++ compiler optimize away unused return value?
Best Practice: function return value or byref output parameters?
C++ having cin read a return character
Checking Unix script ftp return codes.
In Java, does return trump finally?
Hibernate criteria _ how to use criteria to return only one element of an object instead the entire object
What's the best way to return multiple values from a function in Python?