views:

47

answers:

2

Yesterday I asked a question about copying objects in C#, and most answers focussed on the difference between deep copy and shallow copy, and the fact that it should be made clear which of both copy variants a given copy constructor (or operator, or function) implements. I find this odd.

I wrote a lot of software in C++, a language that heavily relies on copying, and I never ever needed multiple copy variants. The only kind of copy operation I ever used is the one I call "deep enough copy". It does the following:

  • In case the object has ownership over the member variable (cf. composition), it is copied recursively.
  • In case the object has no ownership over the member variable (cf. aggregation), only the link is copied.

Now, my question is threefold:

+3  A: 

An object only needs to copy what it needs to copy. Though this question is marked language agnostic, and you mentioned C++, I prefer to explain in C# terms (since, that's what I'm most familiar with). However, the concepts are similar.

Value types are like structs. They live directly in an object instance. Therefore, when you copy the object, you have no choice but to copy the value type. So, you generally don't have to worry about those.

Reference types are like pointers, and this is where it gets tricky. Depending on what the reference type is, you may or may not want a deep copy. A general rule of thumb is that if a reference type (as a member of the object) depends on the state of the outer object, it should be cloned. If not, and never will, it doesn't have to be.

Another way of thinking is that an object passed in to your object from the outside probably should NOT be cloned. An object generated BY your class, should be.

Okay, I lied, I will use some C++ since it will best explain what I mean.

class MyClass {
    int foo;
    char * bar;
    char * baz;

public: MyClass(int f, char * str) {
        this->foo = f;
        bar = new char[f];
        this->baz = str;
    }
};

With this object, there are two string buffers that need to be dealt with. The first one, bar, is created and managed by the class itself. When you clone the object, you should allocate a new buffer.

baz, on the other hand, should not be. In fact, you can't, since you don't have enough information to do so. The pointer should just be copied.

And, of course, foo is just a number. Just copy it, there's nothing else to worry about :)

In summary, to answer your questions directly:

  1. 99% of the time, no. There's only one way to copy that makes sense. What that way is, however, varies.
  2. Not directly. Documenting it is a good idea, but anything internal should stay internal.
  3. Just "Deep copy". You should (Edit: ALMOST) never try to clone an object or pointer you don't control, so that's exempt from the rules :)
Mike Caron
I agree in most of the answer, but there are corner cases. In some situations a resource is created externally and passed in to the constructor (think dependency injection) but the instance keeps ownership of the resource (semantically in C#, physically in C++). In that case it might be appropriate to clone a resource that was handed externally.
David Rodríguez - dribeas
Again, there's always exceptions. I guess I forgot my try{} catch{} block ;)
Mike Caron
It was a joke, about making Exceptions :) Also, I missed a single colon, so sue me >_>
Mike Caron
+1  A: 

Most C++ programmers do not use the terms "shallow copy" and "deep copy" for the very good reason that there is only normally one way to copy an object. This is particularly true in C++ because the compiler uses the copy constructor in many situations where the programmer could tell it which copy constructor to use - for example:

void f( std::string s );

there is no way of telling the compiler how to copy the string.

anon
Dimitri C.
@Dimitri As I suggested elsewhere, you need to clarify what you mean by deep and shallow copy. I've been using C++ for over 20 years and I've never heard the terms used with reference to it, and never seen the terms used in about it.
anon