views:

27

answers:

2

Working through Michael Hartl's RailsTutorial and came across the following error - even though I have followed everything to the 'T'.

1) UsersController GET 'index' for signed-in users should have an element for each user
Failure/Error: response.should have_selector("li", :content => user.name)
undefined method `name' for #<Array:0x000001032c07c8>

Did anyone else get a similar error and know how to fix it?

I am in Chapter 10.

Btw, when I try the page it does what it is supposed to do. It's just that the test fails in RSpec.

FYI, here is the related test code from the users_controller_spec.rb

require 'spec_helper'

describe UsersController do
    render_views

    describe "GET 'index'" do

        describe "for non-signed-in users" do
            it "should deny access" do 
                get :index
                response.should redirect_to(signin_path)
                flash[:notice].should =~ /sign in/i
            end
        end

        describe "for signed-in users" do 

            before(:each) do 
                @user = test_sign_in(Factory(:user))
                second = Factory(:user, :email => "[email protected]")
                third = Factory(:user, :email => "[email protected]")

                @users = [@user, second, third]
            end

            it "should be successful" do 
                get :index
                response.should be_success
            end

            it "should have the right title" do 
                get :index
                response.should have_selector("title", :content => "All users")
            end

            it "should have an element for each user" do
                get :index
                @users.each do |user|
                    response.should have_selector("li", :content => user.name)
                end
            end
        end
    end

My spec/spec_helper.rb file looks like the following:

require 'rubygems'
require 'spork'

Spork.prefork do
  # Loading more in this block will cause your tests to run faster. However, 
  # if you change any configuration or code from libraries loaded here, you'll
  # need to restart spork for it take effect.
  ENV["RAILS_ENV"] ||= 'test'
  unless defined?(Rails)
    require File.dirname(__FILE__) + "/../config/environment"
  end
  require 'rspec/rails'

  # Requires supporting files with custom matchers and macros, etc,
  # in ./support/ and its subdirectories.
  Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}

  Rspec.configure do |config|
    # == Mock Framework
    #
    # If you prefer to use mocha, flexmock or RR, uncomment the appropriate line:
    #
    # config.mock_with :mocha
    # config.mock_with :flexmock
    # config.mock_with :rr
    config.mock_with :rspec

    config.fixture_path = "#{::Rails.root}/spec/fixtures"

    # If you're not using ActiveRecord, or you'd prefer not to run each of your
    # examples within a transaction, comment the following line or assign false
    # instead of true.
    config.use_transactional_fixtures = true

    ### Part of a Spork hack. See http://bit.ly/arY19y
    # Emulate initializer set_clear_dependencies_hook in 
    # railties/lib/rails/application/bootstrap.rb
    ActiveSupport::Dependencies.clear

    def test_sign_in(user)
        controller.sign_in(user)
    end

    def integration_sign_in(user)
        visit signin_path
        fill_in :email,             :with => user.email
        fill_in :password,          :with => user.password 
        click_button
    end    
  end
end

Spork.each_run do
end
A: 

it appears your test_sign_in method is returning an instance of an array rather than a User object. Are you explicitly returning a user object in the test_sign_in method? If not, have a look at the last line that's executed in that method, I have a feeling the result of it is an array.

Patrick Klingemann
This is the definition for test_sign_in `def test_sign_in(user) controller.sign_in(user) end`
marcamillion
Seems to me that it is returning a regular object, not an array. Given that I am just learning, I could be mistaken...but am I correct? By the way, I have updated my post to include the code of my spec/spec_helper.rb file, in case you can find any clues there. That's where my test_sign_in method is declared.
marcamillion
A: 

I solved this issue, and the answer can be found on the railstutorial official forums.

marcamillion