views:

111

answers:

2

First of all, I understand in 90% of applications the performance difference is completely irrelevant, but I just need to know which is the faster construct. That and...

The information currently available on them on the net is confusing. A lot of people say foreach is bad, but technically it should be faster since it's suppose to simplify writing a array traversal using iterators. Iterators, which are again suppose to be faster, but in PHP are also apparently dead slow (or is this not a PHP thing?). I'm talking about the array functions: next() prev() reset() etc. well, if they are even functions and not one of those PHP language features that look like functions.

To narrow this down a little: I'm not interesting in traversing arrays in steps of anything more then 1 (no negative steps either, ie. reverse iteration). I'm also not interested in a traversal to and from arbitrary points, just 0 to length. I also don't see manipulating arrays with more then 1000 keys happening on a regular basis, but I do see a array being traversed multiple times in the logic of a application! Also as for operations, largely only string manipulation and echo'ing.

Here are few reference sites:
http://www.phpbench.com/
http://www.php.lt/benchmark/phpbench.php

What I hear everywhere:

  • foreach is slow, and thus for/while is faster
  • PHPs foreach copies the array it iterates over; to make it faster you need to use references
  • code like this: $key = array_keys($aHash); $size = sizeOf($key);
    for ($i=0; $i < $size; $i++)
    is faster then a foreach

Here's my problem. I wrote this test script: http://pastebin.com/1ZgK07US and no matter how many times I run the script, I get something like this:

foreach 1.1438131332397
foreach (using reference) 1.2919359207153
for 1.4262869358063
foreach (hash table) 1.5696921348572
for (hash table) 2.4778981208801

In short:

  • foreach is faster then foreach with reference
  • foreach is faster then for
  • foreach is faster then for for a hash table

Can someone explain?

  1. Am I doing something wrong?
  2. Is PHP foreach reference thing really making a difference? I mean why would it not copy it if you pass by reference?
  3. What's the equivalent iterator code for the foreach statement; I've seen a few on the net but each time I test them the timing is way off; I've also tested a few simple iterator constructs but never seem to get even decent results -- are the array iterators in PHP just awful?
  4. Are there faster ways/methods/constructs to iterate though a array other then FOR/FOREACH (and WHILE)?

PHP Version 5.3.0


Edit: Answer With help from people here I was able to piece together the answers to all question. I'll summarize them here:

  1. "Am I doing something wrong?" The consensus seems to be: yes, I can't use echo in benchmarks. Personally, I still don't see how echo is some function with random time of execution or how any other function is somehow any different -- that and the ability of that script to just generate the exact same results of foreach better then everything is hard to explain though just "you're using echo" (well what should I have been using). However, I concede the test should be done with something better; though a ideal compromise does not come to mind.
  2. "Is PHP foreach reference thing really making a difference? I mean why would it not copy it if you pass by reference?" ircmaxell shows that yes it is, further testing seems to prove in most cases reference should be faster -- though given my above snippet of code, most definitely doesn't mean all. I accept the issue is probably too non-intuitive to bother with at such a level and would require something extreme such as decompiling to actually determine which is better for each situation.
  3. "What's the equivalent iterator code for the foreach statement; I've seen a few on the net but each time I test them the timing is way off; I've also tested a few simple iterator constructs but never seem to get even decent results -- are the array iterators in PHP just awful?" ircmaxell provided the answer bellow; though the code might only be valid for PHP version >= 5
  4. "Are there faster ways/methods/constructs to iterate though a array other then FOR/FOREACH (and WHILE)?" Thanks go to Gordon for the answer. Using new data types in PHP5 should give either a performance boost or memory boost (either of which might be desirable depending on your situation). While speed wise a lot of the new types of array don't seem to be better then array(), the splpriorityqueue and splobjectstorage do seem to be substantially faster. Link provided by Gordon: http://matthewturland.com/2010/05/20/new-spl-features-in-php-5-3/

Thank you everyone who tried to help.

I'll likely stick to foreach (the non-reference version) for any simple traversal.

+1  A: 

My personal opinion is to use what makes sense in the context. Personally I almost never use for for array traversal. I use it for other types of iteration, but foreach is just too easy... The time difference is going to be minimal in most cases.

The big thing to watch for is:

for ($i = 0; $i < count($array); $i++) {

That's on expensive loop, since it calls count on every single iteration. So long as you're not doing that, I don't think it really matters...

As for the reference making a difference, PHP uses copy-on-write, so if you don't write to the array, there will be relatively little overhead while looping. However, if you start modifying the array within the array, that's where you'll start seeing differences between them (since one will need to copy the entire array, and the reference can just modify inline)...

As for the iterators, foreach is equivalent to:

$it->rewind();
while ($it->valid()) {
    $key = $it->key();     // If using the $key => $value syntax
    $value = $it->current();

    // Contents of loop in here

    $it->next();
}

As far as there being faster ways to iterate, it really depends on the problem. But I really need to ask, why? I understand wanting to make things more efficient, but I think you're wasting your time for a micro-optimization. Remember, Premature Optimization Is The Root Of All Evil...

Edit: Based upon the comment, I decided to do a quick benchmark run...

$a = array();
for ($i = 0; $i < 10000; $i++) {
    $a[] = $i;
}

$start = microtime(true);
foreach ($a as $k => $v) {
    $a[$k] = $v + 1;
}
echo "Completed in ", microtime(true) - $start, " Seconds\n";

$start = microtime(true);
foreach ($a as $k => &$v) {
    $v = $v + 1;
}
echo "Completed in ", microtime(true) - $start, " Seconds\n";

$start = microtime(true);
foreach ($a as $k => $v) {}
echo "Completed in ", microtime(true) - $start, " Seconds\n";

$start = microtime(true);
foreach ($a as $k => &$v) {}    
echo "Completed in ", microtime(true) - $start, " Seconds\n";

And the results:

Completed in 0.0073502063751221 Seconds
Completed in 0.0019769668579102 Seconds
Completed in 0.0011849403381348 Seconds
Completed in 0.00111985206604 Seconds

So if you're modifying the array in the loop, it's several times faster to use references...

And the overhead for just the reference is actually less than copying the array (this is on 5.3.2)... So it appears (on 5.3.2 at least) as if references are significantly faster...

ircmaxell
Don't you mean "[Not-planned] optimization is the root of all evil"? ;) Well thing is all of them do the same thing, so it's not so much a optimization as it is: which is "the better standard way to adopt." Also some more questions unanswered: You say because it doesn't have to copy, but isn't the use of reference a overhead too? stillstanding's comment in my question seems to disagree with your assumptions as well. Also, why is the code producing slower for reference there as well. Did the foreach change in 5.3.0 to convert any array() to a object (eg. SplFixedArray)?
srcspider
@srcspider: Edited answer with benchmark code and results showing references are indeed much faster than non-references...
ircmaxell
@srcspider `"the better standard way to adopt." ` performance is not the only criteria to choose what to adopt. especially in such a farfetched case. Frankly, you're just wasting your time
Col. Shrapnel
@Col. Shrapnel I agree 100%. Readability and maintainability trump performance by a large margin in this particular case... I agree about picking a standard and sticking with it, but base that standard upon other --more important-- factors...
ircmaxell
@ircmaxell: quickly running your script seems to prove your point but I want to look into it a little further; I might edit my original question with more teststo including some of the new 5.3 features. @Col. Shrapnel: FOR is almost universal programing-kindergardn level, FOREACH is simpler syntax. As far as readability they seem to be on equal ground. This is all so low level I don't think maintenance is a issue as would be for some high level pattern. And I don't think I'm wasting my time since this "basic construct" would account for a lot of code I would write. :)
srcspider
@ircmaxell: I've done some more testing, but mostly it was inconclusive. Thanks you for answering a good chunk of the questions. I've edited the first post, to contain the answers to the other questions as well.
srcspider
A: 

One thing to watch out for in benchmarks (especially phpbench.com) is the even though the numbers are sound, the tests are not. Alot of the tests on phpbench.com are doing things at are trivial and abuse PHP's ability to cache array lookups to skew benchmarks or in the case of iterating over an array doesn't actually test it in real world cases (no one writes empty for loops). I've done my own benchmarks that I've found are fairly reflective of the real world results and they always show the language's native iterating syntax foreach coming out on top (surprise, surprise).

    //make a nicely random array
    $aHash1 = range( 0, 999999 );
    $aHash2 = range( 0, 999999 );
    shuffle( $aHash1 );
    shuffle( $aHash2 );
    $aHash = array_combine( $aHash1, $aHash2 );


    $start1 = microtime(true);
    foreach($aHash as $key=>$val) $aHash[$key]++;
    $end1 = microtime(true);

    $start2 = microtime(true);
    while(list($key) = each($aHash)) $aHash[$key]++;
    $end2 = microtime(true);


    $start3 = microtime(true);
    $key = array_keys($aHash);
    $size = sizeOf($key);
    for ($i=0; $i<$size; $i++) $aHash[$key[$i]]++;
    $end3 = microtime(true);

    $start4 = microtime(true);
    foreach($aHash as &$val) $val++;
    $end4 = microtime(true);

    echo "foreach ".($end1 - $start1)."\n"; //foreach 0.947947025299
    echo "while ".($end2 - $start2)."\n"; //while 0.847212076187
    echo "for ".($end3 - $start3)."\n"; //for 0.439476966858
    echo "foreach ref ".($end4 - $start4)."\n"; //foreach ref 0.0886030197144

    //For these tests we MUST do an array lookup,
    //since that is normally the *point* of iteration
    //i'm also calling noop on it so that PHP doesn't
    //optimize out the loopup.
    function noop( $value ) {}

    //Create an array of increasing indexes, w/ random values
    $bHash = range( 0, 999999 );
    shuffle( $bHash );

    $bstart1 = microtime(true);
    for($i = 0; $i < 1000000; ++$i) noop( $bHash[$i] );
    $bend1 = microtime(true);

    $bstart2 = microtime(true);
    $i = 0; while($i < 1000000) { noop( $bHash[$i] ); ++$i; }
    $bend2 = microtime(true);


    $bstart3 = microtime(true);
    foreach( $bHash as $value ) { noop( $value ); }
    $bend3 = microtime(true);

    echo "for ".($bend1 - $bstart1)."\n"; //for 0.397135972977
    echo "while ".($bend2 - $bstart2)."\n"; //while 0.364789962769
    echo "foreach ".($bend3 - $bstart3)."\n"; //foreach 0.346374034882
Kendall Hopkins