In Team Foundation Server, I know that you can use the "Annotate" feature to see who last edited each line in a particular file (equivalent to "Blame" in CVS). What I'd like to do is akin to running Annotate on every file in a project, and get a summary report of all the developers who have edited a file in the project, and how many line...
I'm working on a project with a team where we check in early and often. Individual checkins are completed to the satisfaction of the developer doing the change (including tests where possible) but sometimes the direction of work changes slightly and previous commits need to be reverted and done another way. Or, stub code is filled out in...
In php I have open a .php file and want to evaluate certain lines. Specifically when the $table_id and $line variables are assigned a value. Within the text file I have: ... $table_id = 'crs_class'; // table name $screen = 'crs_class.detail.screen.inc'; // file identifying screen structure ... amongst other l...
I have to support a Java Programming Challenge for students and we have to come up with some technical criteria to judge their java application. What is the best way to compare and judge an application, based on the code and the documentation? Edit to give more details about the challenge: The students are supposed to develop an applica...
What are the best places for freelancers or small companies to get code reviewed for PHP and JavaScript? Forums are an option, but are there any sites dedicated specifically to code reviews? Edit: Just for clarification, I'm looking more for a website to get the code critiqued by others than a tool that helps perform internal code revi...
So I work in a shop that doesn't conduct code reviews. What are some of the best practices out there that actually work? ...
I'm an architect doing reviews on the code checkins of many developers using TFS. Currently, I have to use Source Control history to see individual checkins, then for each checkin I have a list of changed files, and I must double click each file to see its changes (if it was existing) or its contents (if it's new). This is time consumin...
Hi there, Browsing stackoverflow, I noticed a number of posts stating that some developers advocate code review before checkin to MAIN. However, can this really be enforced? And if so, surely it reduces the likelihood of code being refactored due to the increased overhead involved? Personally, I prefer the approach of employing continu...
I want to be able to do a peer code review with Subversion, but what's the easiest way to do this without installing a server application or paying for an online service? PS: This is a .Net project in Visual Studio. ...
I ve been doing code review (mostly using tools like FindBug) of one of our pet projects and FindBug marked following code as errorneus (pseudocode): Connection conn = dataSource.getConnection(); try{ PreparedStatement stmt = conn.prepareStatement(); //initialize the statement stmt.execute(); ResultSet rs = stmt.getRes...
This isn't so much as a question, as an idea which I think would be helpful. I decided to post it here to get feedback on the idea. I'm not sure if this isn't exactly the right place to post it, but I wanted to see what you guys think. My idea is to create an code checkin policy which displays a diff of each modified file. To be able to...
Everyone that has ever had to perform any form of code review has probably been here. You're a member of a code review team, and during the code review you come to an issue where a member of the team is overly aggressive about their viewpoint of a solution, whether it is right or wrong. How would you handle such a situation, especial...
What sorts of things do you look for in a code review when using continuous integration? It seems like a lot of the literature around for code reviews mentions things like coding style, spelling mistakes, resource usage, error handling, etc. (perhaps not in that order :-) However tools like FxCop and StyleCop seem to pick up a most of th...
I'm a PhD student in mechanical engineering without an extensive background in computer science. We write code as part of our research, but it's usually high-level (e.g., Matlab) and often rather ad-hoc. It sounds like code reviews amongst the academics here would be valuable for (a) learning techniques from other people, and (b) spott...
I've recently moved from a company with 30 or so developers all based on the same site, to a smaller company with a total of 6 developers working all over the country. Previously when I was conducting code reviews I'd have the person sitting next to me, or I'd go round to his/her Pc and go over the code with them. At my new company thi...
I'm processing, let's say a list of "Document" objects. Before I record the processing of the document successful I first want to check a couple of things. Let's say, the file referring to the document should be present and something in the document should be present. Just two simple checks for the example but think about 8 more checks b...
Step into the confessional. Now's your time to come clean. What's the worst code you personally have ever written? Why was it so bad? What did you learn from it? Don't tell us about code you inherited or from some co-worker. This is about your personal growth as a programmer and as a person. ...
I've read a bit about Google's Mondrian, and I've seen Atlassian's Crucible demonstrated - I'm convinced that the tools have value. Are there open-source code review tools? It would be used on a proprietary codebase, so it can't be a public site or service (eg: Google Code's features include some of those of Crucible). We have release...
Does anyone know about free code review solutions out there (for asp.net)? I am trying to find something that is free or inexpensive for a startup. Also, It would be nice if it had some sort of subversion integration, as this is always a pain to manage manual diff files vs. reviewing the differences between two different revisions. I w...
I want to better understand the patterns that work and the patterns that don't work for successful code reviews. Should there be a difference be a Formal Code Review and an Informal Code Review? What level of documentation of the Code Review do people do? Can a Code Review be just as useful without the author of the code participatin...