+9  A: 

You can get the assembly code from your compiler and compare them. At least in GCC, they produce identical code.

Lukáš Lalinský
Of course, you can. But should you? Engineering should come first as long as it isn't shown that it considerably hinders performance. So IMO this question should be answered from en engineering POV. (I like http://stackoverflow.com/questions/1650792/1650849#1650849.)
sbi
From what I've understood, the question was about "process cycles", not about functional differences between the two options.
Lukáš Lalinský
The question pretty clearly states that Jenner prefers it the other way, but is concerned about speed. Why shouldn't he be told that the concern is misplaced?
sbi
Didn't I tell him that? There might be huge difference between them and there might be none. What if there was some magic behind passing by reference? What if it was 1000x slower? You wouldn't know until you try/read/ask. I believe it's important to know low-level semantics of the language you are using, so that you can make the right decisions. It's like arguing which word to use in a natural language, without knowing what the words actually mean.
Lukáš Lalinský
"Didn't I tell him that?" Not in your answer, anyway. "What if there was some magic behind passing by reference?" Then we'd be talking about semantics, not performance. "What if it was 1000x slower?" If so, looking at the assembler code wouldn't be necessary.
sbi
+3  A: 

Here's the difference in the generated assembly with g++. a.cpp is pointers, b.cpp is references.

$ g++ -S a.cpp

$ g++ -S b.cpp

$ diff a.S b.S
1c1
<       .file   "a.cpp"
---
>       .file   "b.cpp"
4,6c4,6
< .globl __Z7MyFunc1PiS_
<       .def    __Z7MyFunc1PiS_;        .scl    2;      .type   32;     .endef
< __Z7MyFunc1PiS_:
---
> .globl __Z7MyFunc1RiS_
>       .def    __Z7MyFunc1RiS_;        .scl    2;      .type   32;     .endef
> __Z7MyFunc1RiS_:

Just the function name is slightly different; the contents are identical. I had identical results when I used g++ -O3.

Mark Rushakoff
+8  A: 

My rule of thumb is to pass by pointer if the parameter can be NULL, ie optional in the cases above, and reference if the parameter should never be NULL.

dominic hamon
Right. This kind of micro-optimization should not be attempted unless profiling shows it's necessary. Until then, prefer a good engineering. I happen to agree with this one. Unfortunately, I can't give it 3 up-votes.
sbi
Pavel Minaev
A: 

References are very similar to pointers with one big difference: references can not be NULL. So you no not need to check if they are acutual usable objects (like for pointers).

Therefore I assume that compilers will produce the same code.

fmuecke
Be careful with this, though, since references can actually be NULL. You shouldn't check for it, of course, but keep in mind that your code could still crash on a NULL reference (in case it matters for your application).
Jim Buck
TTBOMK, a reference can only be `NULL` if someone maliciously invoked undefined behavior in order to set a reference to `NULL`. If you want to be careful because of _that_ possibility, you must not trust anything else in your code either.
sbi
@Jim: References cannot be NULL in a valid program. Sure, you can perform a nasty hack to make it happen, but at that point the program is allowed to turn your screen blue and summon Zeus to sleep with your cousins, so a reference being NULL is the least of your problems.
Kaz Dragon
@Kaz: That might depend on your cousins. `:)`
sbi
References can't be null in general, but the case to watch out for is where you've stored a reference to a variable that has gone out of scope. For example, returning a reference to a local variable in a function.
mch
If you have a lot of pointer-based code, and you need to interface with a library that uses references, you have to use the dereference operator to call into that library. If your pointer-based code can have NULLs, then when you dereference, you will most certainly have a NULL reference. Sure, the result is undefined, but so is accessing NULL pointers in code that is only pointer-based.
Jim Buck
@Jim: But dereferencing a pointer without checking for `NULL` _is_ malicious.
sbi
+11  A: 

From a performance point of view, it probably doesn't matter. Others have already answered that.

Having said that, I have yet not found a situation where an added instruction in this case would make a noticeable difference. I do realize that for a function that is called billions of times, it could make a difference. As a rule, you shouldn't adapt your programming style for these kind of "optimizations".

Mattias Nilsson
++ Hear, hear !
Mike Dunlavey
+1 for the "looking for optimizations in all the wrong places" notion.
DarkSquid
@DarkSquid: I can almost hear the country-music tune...
Mike Dunlavey
+5  A: 

This will get voted down since it's Old Skool, but I often prefer pointers since it's easier to just glance at code and see if my objects that I am passing to a function could get modified, especially if they are simple datatypes like int and float.

Jim Buck
While I happen to not to be in this camp (I subscribe this this argument: http://stackoverflow.com/questions/1650792/1650849#1650849), I see it as a valid argument. +1
sbi
Oops, I only noticed your reply after adding my own (which basically repeats your argument). +1 for you.
Frerich Raabe
Pavel Minaev
I agree - http://stackoverflow.com/questions/334856/are-there-benefits-of-passing-by-pointer-over-passing-by-reference-in-c/334944#334944
Michael Burr
A: 

You should see the generated assembly code for the target machine... take into account that a function call is always done in constant time, and on actual machines that time is really negligible...

JPCF
+1  A: 

All the other answers already point out that neither function is superior to the other in terms of runtime performance.

However, I think that that the former function is superior to the other in terms of readability, because a call like

f( &a, &b );

clearly expresses that a reference to some variable is passed (which, to me, rings the 'this object might be modified by the function' bell). The version which takes references instead of pointers just looks like

f( a, b );

It would be fairly surprising to me to see that a changed after the call, because I cannot tell from the invocation that the variable is passed by reference.

Frerich Raabe
+2  A: 

There are different guidelines on using reference vs. pointer parameters out there, tailored to different requirements. In my opinion, the most meaningful rule that should be applied in generic C++ development is the following:

  1. Use reference parameters when overloading operators. (In this case you actually have no choice. This is what references were introduced for in the first place.)

  2. Use const-reference for composite (i.e. logically "large") input parameters. I.e input parameters should be passed either by value ("atomic" values) or by const-reference ("aggregate" values). Use pointers for output parameters and input-output parameters. Do not use references for output parameters.

Taking the above into the account, the overwhelming majority of reference parameters in your program should be const-references. If you have a non-const reference parameter and it is not an operator, consider using a pointer instead.

Following the above convention, you'll be able to see at the point of the call whether the function might modify one of its arguments: the potentially modified arguments will be passed with explicit & or as already-existing pointers.

There's another popular rule out there that states that something that can be null should be passed as a pointer, while something that can't be null should be passed as a reference. I can imagine that this might make sense in some very narrow and very specific circumstances, but in general this is a major anti-rule. Just don't do it this way. If you want to express the fact that some pointer must not be null, put a corresponding assertion as the very first line of your function.

As for the perfromance considerations, there's absolutely no performance difference in passing by pointer or passing by reference. Both kinds of parameters are exactly the same thing at the physical level. Even when the function gets inlined, a modern compiler should be smart enough to preserve the equivalence.

AndreyT