code-review

Check for private API "usage" yourself?

So, we all know Apple forbids using private or undocumented APIs in iOS apps. I have no problem with this, as there are sound technical reasons for why this is a good idea. However, twice now I've had an app rejected for using private APIs, when this was not actually the case. It's not difficult -- the private APIs include symbols like c...

Java: Good algorithm for removing an element from a linked list?

I have a pretty basic question here. I am implementing a few operations on a linked list as an exercise. One such operation is removal: /** * Removes the element at index. * @param index * @throws IndexOutOfBoundsException If index is greater than the list's length. */ public void remove(int index) throws IndexOutOfBoundsExceptio...

Good Code Review Software available?

It's been 18 months since the same kind of question was asked. This is an update. I've been searching around for free Code Review Software but couldn't find a definitive answer to find a good tool that would be easy to setup for our team. My list includes: reitveld, running on Google App Engine. Review Board, from VMWare. Codestriker,...

Mercurial and code reviews; good workflow?

I'm in a small distributed team using Mercurial for a central repository. We each clone it via ssh onto our own linux boxes. Our intent is to review each others' work before pushing changes up to the central repository, to help keep central's tip clean. What is a good way to share code between developers on different linux boxes? I'm new...

Code Review tools that integrates with Visual Studio 2008 and/or TFS 2008?

I'd like to know what kind of options we have regarding tools for performing code reviews. We're a group of 15 people that uses Visual Studio 2008, writing code in C# 3.0 for .NET 3.5 (at least for the time being), and using TFS 2008 for source control. I've looked at TeamReview on CodePlex, but it seems the only way I can create revie...

Code Review tools for Team Foundation Server 2010

We just moved to TFS 2010 and we would like to use a tool for code review. We are looking at Team Review (http://teamreview.codeplex.com/) from codeplex. Do any of you guys recommend any tool that can perform code review for TFS 2010? Management is open to use opensource tools but is willing to allocate budget if the tool is well worth t...

traversing a table, whats wrong with my code?

public partial class Table_Traversing : System.Web.UI.Page { Table table1 = new Table(); TableRow table_row1 = new TableRow(); TableCell table_cell1 = new TableCell(); TableCell table_cell2 = new TableCell(); Label The_text = new Label(); CheckBox checkmate = new CheckBox(); Button button1 = new Button(); public void ...

Web based code review tool for git

I'm using git with trac and I need some simple code review tool. I just need the ability to write some comments on some lines on each commit. I've googled a litte and found gerrit, but It seems too complex for my needs. I also found trac plugin http://trac-hacks.org/wiki/CodeReviewPlugin, I will try it. But maybe you can pont to some be...

Embedded C code review

Hi, I am required to write a function that uses a look up table for ADC values for temperature sensor analog input, and it finds out the temperature given an ADC value by "interpolating" - linear approximation. I have created a function and written some test cases for it, I want to know if there is something which you guys can suggest to...

Why do the rows of Table1 on post back become null?

The problem is: On postback, the table does not have the rows that were dynamically created, the rowcount is 0. Click on the button, it should detect the checked checkboxes within the table dynamically generated. The table is made by code when the "day" is selected using the drop down list and "the starting date" is selected using the ...

dynamic creation, adding row and cols in table works, but on button click things go wrong! REVISED

select day using the drop down list select the start date using calender (causes an event), a table is made having the dates of the day selected from the start date and shown to the user. the table also contains checkbox for each row in a cell the user selects the check boxes he wants and clicks the button the button calls the method in...

PHP Print only select rows for SQL Enquiry Results.

In PHP I am having difficulty trying to extract row data from one SQL Query results. The service information I require is stored in an array called $SelectedItems. The Code below works as it should but Prints the Entire table with all rows. How would I get it to simply print the 1 row. $sql ="select blah blah" //Output result ...

Code review / Commit review. Looking for process and tool feedback

Let me start by describing what our current 'process' is and then ask you how we should improve on it and what, if any, tools you would suggest. What we are doing currently Every time someone makes a commit to our svn (or pushes git changes into 'trunk') it ends up in an email in one persons inbox. That person is responsible for glanci...

What's on your javascript code review checklist

I'm implementing a code review process, among the things to be reviewed is javascript. I've been asked to make a sort of checklist of things to look for when reviewing code. So far my checklist is as follows: no functions or variables in the global namespace. write efficient code, especially in loops don't append to the dom in a loop. ...

When should assert() be used?

In developing a large C++ programming project with many developers, we have run into issues with inappropriate use of assert() in the code which results in poor quality where the assertion does indeed occur and the product crashes. The question is what are good principles to apply to use assert() appropriately? When is it proper to use...

Is there a pattern for this? Common base class with special actions for certain child classes

I have code that when given a thing it needs to sort out what specific kind of thing it is and then take special actions based on that. The possible classes it could be are all desc public void doSomething(BaseThing genericThing) { if (genericThing instanceof SpecificThing) { SpecificThingProcessor stp = new SpecificThingProces...

Best code review tool for GIT

Is there a an open source or free code review tool that works best with GIT? 1.Have tried gerrit but is there a better open source or free code review tool? 2.Is there a code review that is capable of showing changes in the web before the user commits to the repository? Does ReviewBoard or any other tools have this feature? ...

Books for Code review

Hi All, Can anyone please suggest me books which teaches towards making better code reviews? Basically, best practices for coding. Regards ...

Workflow for GitHub-based code review

I'm considering using GitHub as our primary tool for doing code review. With features like in-line commenting and compare view, it seems to have a lot of features that tools like Gerrit have on offer. Has anyone else used GitHub for this? If so, what is your workflow? And what have your experiences been doing so, both positive and negat...

Multiple lines comments in Scheme (RnRS)

I created this solution: ; use like this: ; (/* content ... */ <default-return>) ; or ; (/* content ... */) => #f (define-syntax /* (syntax-rules (*/) ((/* body ... */) #f) ((/* body ... */ r) r))) But is it really the best or easy way? ...