peer-review

Online Peer Code Review?

For people who work on very small teams, or by themselves, or on teams where they are by far the best developer and have a need to learn from someone better than them, are there any online resources/methods for doing some sort of peer code review? I used to be pretty active in the online art community (specifically drawing anime) and th...

Peer Reviews or Pair Programming, or Both?

Do you participate in code peer reviews or practice pair programming, or both? Have you been able to demonstrate an increase in software quality using these practices? What benefits and drawbacks have you observed in the course of practice? What hurdles to implementation did you face? In my own case, our development team pursued...

Simple C++ function -- Is this code "good"?

The following code was produced by a consultant working for my group. I'm not a C++ developer (worked in many languages, though) but would like some independent opinions on the following code. This is in Visual Studio C++ 6.0. I've got a gut reaction (not a good one, obviously), but I'd like some "gut reactions" from seasoned (or even...

Boost like libraries in C

Hi, Can you recommend peer reviewed libraries that I can use in C environment (something like Boost for C++) ? Something that provides hash, thread, interprocess communications, lists, smart memory management... The environment is embedded system, not a very minimal system, but also not a PC! Thanks! Amit ...

Recommendation for text-based software design review collaboration tool

Much of the software design we do in our company is in Microsoft Word, embedding pictures and Visio diagrams where necessary. Can anyone recommend a good software design review collaboration tool that allows multiple parties to give review feedback in parallel? Currently, we use various methods none of which are ideal: Using "Insert ...

Review my game project OR (How to peer-review my project) ?

I just finished a 2d platformer in C++/Allegro. Its still in an incomplete stage... I wonder how to go about a peer-review from people who are into game development. I would like to review my project on grounds of game play Collision detection use of OOP programming of sounds, effects etc any further ideas ways in which i could have ...

Commenting code that is removed?

Is it a good practice to comment code that is removed? For example: // Code to do {task} was removed by Ajahn on 10/10/08 because {reason}. Someone in my developer group during a peer review made a note that we should comment the lines of code to be removed. I thought this was a terrible suggestion, since it clutters the code with us...

Yearly Developer Review

What criteria do you rate your developers on when doing their yearly reviews? We are looking to improve our process more than "we feel you did a good job, here is a raise!" We were thinking something like: Attendance Teamwork Quality of Work We are a .NET / C# shop if that helps. ...

Best way to track and enforce peer reviews before commit

I was wondering what mechanism have people used to enforce and track peer reviews for committing to SVN. For each commit I want to be able to track if people have had a peer review (I am not sure whether enforcing a rule where they can't commit is a good idea, my gut feeling is that it shouldn't be enforced as there a probably valid re...

Where can I find Peer Code Review?

I was looking for a website that would allow me to post my C# applications, have people download them and tell me what the like/dislike about them. If you know of one please let me know, or if we can just do it on here. ...

If you pair program, do you still need a peer review?

I think in general Peer reviews are a very good part of development process, they often catch or question things which were not apparent when code was originally written and make you more self conscious so you format better, put in comments etc. However if you are pair programming you effectively have a live peer review, so is it worth...

How do you peer review SRSS reports?

I'm a big fan of peer review of code but when it comes to reports there just doesn't seem like a good way reviewing them. Showing differences just gets you the XML which isn't very readable and opening the report doesn't get you that much more visibility. Are there any applications that make this easier or do most people just review repo...

How to overcome the "Everyone else's code sucks" attitude?

I'm the only programmer at work. A result of downsizing, I have to work on programs that have been created/maintained by many different past programmers. When I look at the code in some of them, I shudder to think that I worked with these people and they produced code like that. Now if I sound big headed and demeaning, well, I'm tryin...

How to ensure correctness of data gathered via crowdsourcing?

I have a site where users are entering data of some products they buy. How do I ensure correctness of data entered via crowdsourcing (enabling users to vote/edit products) minimizing amount of work that needs to be done by administrator? I'm looking for some how-tos, best practices, etc. ...

What would you submit as an example of your best code for peer review?

If your company was being audited, or you were in an interview, and you were asked to provide an example of your best code for peer review, what would you submit? (I would like actual code examples for people to vote on). Try to keep the sample small (less than 100 lines) and for the purposes of this forum lets keep it limited to JAVA, ...

How to prevent (junior)developers making the wrong decisions/bad code?

Short of hovering over the developers and question all decisions they make/code they produce.. Architectural choices, massive codefiles (5k loc), no code commenting or documentation, .. I'm using some Check-in policies in TFS2005 like Changeset Comments Policy, WorkItems, regular code reviews. What works the best in your company? So ...

Is there a site where I can post snippets of code for review?

I'd seen someone post a link to such a site on SO , but I forgot what it was... ...

Constructive Criticism

While peer programing what is the most optimal way to offer constructive criticism? How do you critique without pointing out flaws? ...

Model diagram doesn't seem right. How else can I relate the objects?

Hey, I have a entity diagram from some analysis that I'd like to have someone look over. For some reason the System object just doesn't seem right to me. Is there a better way to relate the objects? Its basically a user authentication/management system in its infancy. http://www.dumpt.com/img/viewer.php?file=zlh8ltbtho4mutbbb3yk.gif ...

How beneficial is a top down code review?

It seems that most code reviews are bottom to top - being that the lower engineers get their code reviewed by the higher ups and the higher ups by the managers or not at all. It occurred to me when working with some new graduates that a top down code review may be a great thing. The idea being that us older guys have probably adopted so...